DOCKER_BUILDKIT=1 is not passed when using docker-compose

[punishell]

DOCKER_BUILDKIT=1 is not passed when using docker-compose it needs to be changed to DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 in order to make e.g:
make localnet-build works

Closes: #XXX

What is the purpose of the change

changes are needed to make commands works e.g: make localnet-build works

Brief Changelog

(for example:)

• passing DOCKER_BUILDKIT=1 to docker-compose

Testing and Verifying

(Please pick one of the following options)

This change is already covered by existing tests.

This change added tests and can be verified as follows:

(example:)

• COMPOSE_DOCKER_CLI_BUILD=1 to Makefile

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? ( no)
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? ( no)
• How is the feature or change documented? (not applicable )

[czarcas7ic]

It seems like make localnet-build and other localnet commands works for me. Tagging @niccoloraspa in case I'm missing something

[niccoloraspa]

I think it was addressed in #2795

[punishell]

Here is a output:

michal@ubuntu:~/osmosis$ sudo make localnet-build
[sudo] password for michal: 
Building osmosisd
Step 1/19 : ARG GO_VERSION="1.18"
Step 2/19 : ARG RUNNER_IMAGE="gcr.io/distroless/static"
Step 3/19 : FROM golang:${GO_VERSION}-alpine as builder
 ---> b68eed002951
Step 4/19 : RUN set -eux; apk add --no-cache ca-certificates build-base; apk add git linux-headers
 ---> Using cache
 ---> 2b27f7b9b243
Step 5/19 : WORKDIR /osmosis
 ---> Using cache
 ---> 0be37bc9bb61
Step 6/19 : COPY go.* ./
 ---> Using cache
 ---> b4dcd46360dd
Step 7/19 : RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,target=/root/go/pkg/mod     go mod download
ERROR: Service 'osmosisd' failed to build: the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled
make: *** [Makefile:364: localnet-build] Error 1

[ValarDragon]

... what?

[ValarDragon]

Does seem like COMPOSE_DOCKER_CLI_BUILD is a common thing env var to set: https://stackoverflow.com/questions/58592259/how-do-you-enable-buildkit-with-docker-compose

But can you explain the nftvuln line / why you included it?

[punishell]

sorry for that but i have been fixing it in GitHub web :D now should be ok

regarding

But can you explain the nftvuln line / why you included it?

looks like i have been doing two things at the same time and copy paste some nonsense sorry

[ValarDragon]

cc @niccoloraspa @czarcas7ic for these, as they are new or different than the old ones.

Everything else LGTM

[punishell]

sure sounds legit

[niccoloraspa]

I think there are too many changes.

I'm happy to add COMPOSE_DOCKER_CLI_BUILD=1 to any Makefile target that is using docker-compose build.
It doesn't make sense to add it to docker build ... commands, though.

For example:

docker-build-debug:
	@DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 docker build -t osmosis:${COMMIT} --build-arg BASE_IMG_TAG=debug -f Dockerfile .

This doesn't make sense. Same for all other targets docker-build-e2e-init-chain, docker-build-e2e-init-node, etc...

To avoid any merge conflicts maybe it's best to fetch main and reapply the relevant changes.

[niccoloraspa]

Hey @punishell,

thanks for the quick updates.
There are some fixes to do before merging:

• COMPOSE_DOCKER_CLI_BUILD=1 must be present only on a docker-compose build command not on the others (up, upd, down). See comments below

• There are some extra spaces added to be removed (See comments below)

Also, there are conflicts to be solved with the current Makefile, could you fix those?

After that, we can merge.

P.S. I saw the comment on the commit about wasting our time . Please don't feel this way, we are grateful for your contributions, and reviewing work is expected.