Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gamm): improve error handling and messages when parsing pool assets #2804

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 20, 2022

Closes: #XXX

What is the purpose of the change

The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages.

This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title refactor(gamm): improve error handling and mesages when parsing pool… refactor(gamm): improve error handling and mesages when parsing pool assets Sep 20, 2022
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 20, 2022
@p0mvn p0mvn changed the title refactor(gamm): improve error handling and mesages when parsing pool assets refactor(gamm): improve error handling and messages when parsing pool assets Sep 20, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Sep 20, 2022
@p0mvn p0mvn marked this pull request as ready for review September 20, 2022 21:28
@p0mvn p0mvn requested a review from a team September 20, 2022 21:28
@ValarDragon ValarDragon added the A:backport/v12.x backport patches to v12.x branch label Sep 28, 2022
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:automerge labels Sep 29, 2022
@mergify mergify bot merged commit f024498 into main Sep 29, 2022
@mergify mergify bot deleted the roman/gamm-errors branch September 29, 2022 18:20
mergify bot pushed a commit that referenced this pull request Sep 29, 2022
… assets (#2804)

Closes: #XXX

## What is the purpose of the change

The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages.

This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes
  - How is the feature or change documented? not applicable

(cherry picked from commit f024498)

# Conflicts:
#	CHANGELOG.md
p0mvn added a commit that referenced this pull request Oct 1, 2022
… assets (backport #2804) (#2901)

* resolve conflicts

* Update CHANGELOG.md

Co-authored-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge A:backport/v12.x backport patches to v12.x branch C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants