Twap: Integrate and Add migration tests #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
approved these changes
Aug 17, 2022
p0mvn
reviewed
Aug 18, 2022
p0mvn
reviewed
Aug 18, 2022
There was a problem hiding this comment.
Great work @mattverse
I skimmed the original issue and I think there might be one point that needs to be addressed:
add an upgrade test for v11, that ensures were still producing blocks with swaps post-upgrade.
I think that implies adding an e2e test. We currently don't have any doins swaps, only creating pools.
Can we either add it here or create an issue, attaching it to the v12 milestone blocker, please?
I'm also happy to help with adding this check to e2e
alexanderbez
approved these changes
Aug 18, 2022
ValarDragon
reviewed
Aug 18, 2022
ValarDragon
reviewed
Aug 18, 2022
ValarDragon
approved these changes
Aug 19, 2022
Co-authored-by: Roman <[email protected]>
|
I think we should merge this after @p0mvn 's comment for transient store being tested is addressed |
|
Addressed! Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2198
What is the purpose of the change
Integrates and adds migration test. The migration logic is implemented using the last pool id, not by creating a method that iterates through all pools and gets all pool IDs.
This PR also introduces test cases for the upgrade itself, and the migration method.
Brief Changelog
Add migration test for existing pools on the twap module.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no