Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper method #2418

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 15, 2022

Closes: #XXX

What is the purpose of the change

SetInitialSupplyOffsetDuringMigration is only used in v7 upgrade. We should never need to use this method anymore. As a result, I propose removing it while keeping the note in v7 upgrade handler about this historic method.

Anyone interested in the historic implementation can check out the v7 branch and see the implementation.

It is useful to avoid having obsolete methods for simplicity of packages and fewer potential sources of misuse and bugs

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:x/mint labels Aug 15, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Aug 15, 2022
@p0mvn p0mvn marked this pull request as ready for review August 15, 2022 20:20
@p0mvn p0mvn requested a review from a team August 15, 2022 20:20
@p0mvn p0mvn added the A:backport/v11.x backport patches to v11.x branch label Aug 15, 2022
@p0mvn p0mvn marked this pull request as draft August 16, 2022 17:26
@p0mvn p0mvn marked this pull request as ready for review August 16, 2022 22:00
@ValarDragon ValarDragon merged commit 3d7d48c into main Aug 19, 2022
@ValarDragon ValarDragon deleted the roman/remove-supply-offset-migration branch August 19, 2022 12:38
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
… method (#2418)

* refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper function

* changelog

* resolve merge conflict

(cherry picked from commit 3d7d48c)

# Conflicts:
#	CHANGELOG.md
#	x/mint/keeper/keeper_test.go
p0mvn added a commit that referenced this pull request Aug 19, 2022
… method (backport #2418) (#2456)

* refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper method (#2418)

* refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper function

* changelog

* resolve merge conflict

(cherry picked from commit 3d7d48c)

# Conflicts:
#	CHANGELOG.md
#	x/mint/keeper/keeper_test.go

* Fix conflict

Co-authored-by: Roman <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v11.x backport patches to v11.x branch C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:x/mint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants