Authz #2206
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import ( | |
| cdctypes "github.com/cosmos/cosmos-sdk/codec/types" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| "github.com/cosmos/cosmos-sdk/types/msgservice" | ||
| authzcodec "github.com/cosmos/cosmos-sdk/x/authz/codec" | ||
| ) | ||
|
|
||
| var ( | ||
|
|
@@ -32,5 +33,10 @@ func RegisterInterfaces(registry cdctypes.InterfaceRegistry) { | |
|
|
||
| func init() { | ||
| RegisterCodec(amino) | ||
| // Register all Amino interfaces and concrete types on the authz Amino codec so that this can later be | ||
| // used to properly serialize MsgGrant and MsgExec instances | ||
| sdk.RegisterLegacyAminoCodec(amino) | ||
| RegisterCodec(authzcodec.Amino) | ||
|
|
||
| amino.Seal() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,21 @@ | ||
| package types | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
| time "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| "github.com/tendermint/tendermint/crypto/ed25519" | ||
|
|
||
| cdctypes "github.com/cosmos/cosmos-sdk/codec/types" | ||
|
|
||
| appParams "github.com/osmosis-labs/osmosis/v10/app/params" | ||
| lockuptypes "github.com/osmosis-labs/osmosis/v10/x/lockup/types" | ||
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| "github.com/cosmos/cosmos-sdk/x/auth/legacy/legacytx" | ||
| "github.com/cosmos/cosmos-sdk/x/authz" | ||
| ) | ||
|
|
||
| // TestMsgCreatePool tests if valid/invalid create pool messages are properly validated/invalidated | ||
|
|
@@ -210,3 +216,72 @@ func TestMsgAddToGauge(t *testing.T) { | |
| } | ||
| } | ||
| } | ||
|
|
||
| func TestAuthzMsg(t *testing.T) { | ||
| appParams.SetAddressPrefixes() | ||
| pk1 := ed25519.GenPrivKey().PubKey() | ||
| addr1 := sdk.AccAddress(pk1.Address()).String() | ||
| coin := sdk.NewCoin("stake", sdk.NewInt(1)) | ||
| someDate := time.Date(1, 1, 1, 1, 1, 1, 1, time.UTC) | ||
|
|
||
| testCases := []struct { | ||
| expectedGrantSignByteMsg string | ||
| expectedRevokeSignByteMsg string | ||
| expectedExecStrSignByteMsg string | ||
| incentivesMsg sdk.Msg | ||
| }{ | ||
| { | ||
| expectedGrantSignByteMsg: `{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgGrant","value":{"grant":{"authorization":{"type":"cosmos-sdk/GenericAuthorization","value":{"msg":"/osmosis.incentives.MsgAddToGauge"}},"expiration":"0001-01-01T02:01:01.000000001Z"},"grantee":"cosmos1def","granter":"cosmos1abc"}}],"sequence":"1","timeout_height":"1"}`, | ||
| expectedRevokeSignByteMsg: `{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgRevoke","value":{"grantee":"cosmos1def","granter":"cosmos1abc","msg_type_url":"/osmosis.incentives.MsgAddToGauge"}}],"sequence":"1","timeout_height":"1"}`, | ||
| expectedExecStrSignByteMsg: fmt.Sprintf(`{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgExec","value":{"grantee":"cosmos1def","msgs":[{"type":"osmosis/incentives/add-to-gauge","value":{"gauge_id":"1","owner":"%s","rewards":[{"amount":"1","denom":"stake"}]}}]}}],"sequence":"1","timeout_height":"1"}`, addr1), | ||
| incentivesMsg: &MsgAddToGauge{ | ||
| Owner: addr1, | ||
| GaugeId: 1, | ||
| Rewards: sdk.NewCoins(coin), | ||
| }, | ||
| }, | ||
| { | ||
| expectedGrantSignByteMsg: `{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgGrant","value":{"grant":{"authorization":{"type":"cosmos-sdk/GenericAuthorization","value":{"msg":"/osmosis.incentives.MsgCreateGauge"}},"expiration":"0001-01-01T02:01:01.000000001Z"},"grantee":"cosmos1def","granter":"cosmos1abc"}}],"sequence":"1","timeout_height":"1"}`, | ||
| expectedRevokeSignByteMsg: `{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgRevoke","value":{"grantee":"cosmos1def","granter":"cosmos1abc","msg_type_url":"/osmosis.incentives.MsgCreateGauge"}}],"sequence":"1","timeout_height":"1"}`, | ||
| expectedExecStrSignByteMsg: fmt.Sprintf(`{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/MsgExec","value":{"grantee":"cosmos1def","msgs":[{"type":"osmosis/incentives/create-gauge","value":{"coins":[{"amount":"1","denom":"stake"}],"distribute_to":{"denom":"lptoken","duration":"1000000000","timestamp":"0001-01-01T00:00:00Z"},"num_epochs_paid_over":"1","owner":"%s","start_time":"0001-01-01T01:01:01.000000001Z"}}]}}],"sequence":"1","timeout_height":"1"}`, addr1), | ||
| incentivesMsg: &MsgCreateGauge{ | ||
| IsPerpetual: false, | ||
| Owner: addr1, | ||
| DistributeTo: lockuptypes.QueryCondition{ | ||
| LockQueryType: lockuptypes.ByDuration, | ||
| Denom: "lptoken", | ||
| Duration: time.Second, | ||
| }, | ||
| Coins: sdk.NewCoins(coin), | ||
| StartTime: someDate, | ||
| NumEpochsPaidOver: 1, | ||
| }, | ||
| }, | ||
| } | ||
| for _, tc := range testCases { | ||
| // Authz: Grant Msg | ||
| typeURL := sdk.MsgTypeURL(tc.incentivesMsg) | ||
| grant, err := authz.NewGrant(someDate, authz.NewGenericAuthorization(typeURL), someDate.Add(time.Hour)) | ||
| require.NoError(t, err) | ||
| msgGrant := &authz.MsgGrant{Granter: "cosmos1abc", Grantee: "cosmos1def", Grant: grant} | ||
| require.Equal(t, | ||
| tc.expectedGrantSignByteMsg, | ||
| string(legacytx.StdSignBytes("foo", 1, 1, 1, legacytx.StdFee{}, []sdk.Msg{msgGrant}, "memo")), | ||
| ) | ||
|
|
||
| // Authz: Revoke Msg | ||
| msgRevoke := &authz.MsgRevoke{Granter: "cosmos1abc", Grantee: "cosmos1def", MsgTypeUrl: typeURL} | ||
| require.Equal(t, | ||
| tc.expectedRevokeSignByteMsg, | ||
| string(legacytx.StdSignBytes("foo", 1, 1, 1, legacytx.StdFee{}, []sdk.Msg{msgRevoke}, "memo")), | ||
| ) | ||
|
|
||
| // Authz: Exec Msg | ||
| msgAny, _ := cdctypes.NewAnyWithValue(tc.incentivesMsg) | ||
| msgExec := &authz.MsgExec{Grantee: "cosmos1def", Msgs: []*cdctypes.Any{msgAny}} | ||
| require.Equal(t, | ||
| tc.expectedExecStrSignByteMsg, | ||
| string(legacytx.StdSignBytes("foo", 1, 1, 1, legacytx.StdFee{}, []sdk.Msg{msgExec}, "memo")), | ||
| ) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import ( | |
| cdctypes "github.com/cosmos/cosmos-sdk/codec/types" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| "github.com/cosmos/cosmos-sdk/types/msgservice" | ||
| authzcodec "github.com/cosmos/cosmos-sdk/x/authz/codec" | ||
| ) | ||
|
|
||
| func RegisterCodec(cdc *codec.LegacyAmino) { | ||
|
|
@@ -30,5 +31,10 @@ var ( | |
|
|
||
| func init() { | ||
| RegisterCodec(amino) | ||
| // Register all Amino interfaces and concrete types on the authz Amino codec so that this can later be | ||
| // used to properly serialize MsgGrant and MsgExec instances | ||
| sdk.RegisterLegacyAminoCodec(amino) | ||
| RegisterCodec(authzcodec.Amino) | ||
|
|
||
| amino.Seal() | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate elaborate here that this test is meant more so to test the authz than the gamm message