Benchmark apptesting setup time #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
approved these changes
Jul 19, 2022
|
Merging since the change is small and doesn't affect non-test logic |
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
(cherry picked from commit 3aecc23)
p0mvn
pushed a commit
that referenced
this pull request
Jul 19, 2022
(cherry picked from commit 3aecc23) Co-authored-by: Dev Ojha <[email protected]>
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds a benchmark for app keeper setup. It currently takes too long, with lots of GC induced. Going to write this in an issue, we should as a backburner task figure out why it creates so much heap and fix it.
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.