Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1904
What is the purpose of the change
This PR adds a test that (trivially) checks to make sure that
IsActive
returns true for balancer pools. The primary purpose of this change is to make sure that if IsActive is ever used as an emergency switch, it is not accidentally left off for any or all pools.I realize that my implementation has more structure than might seem necessary for a test this simple, but given how we intend to add more complex mock tests to cover
IsActive
flipping functionality in the future (#1904 (comment)), I figured setting it up properly the first time around might make it easier to implement these other tests later.Brief Changelog
IsActive
always returns trueTesting and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (no)