Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic test for IsActive #2050

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Add basic test for IsActive #2050

merged 3 commits into from
Jul 13, 2022

Conversation

AlpinYukseloglu
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu commented Jul 13, 2022

Closes: #1904

What is the purpose of the change

This PR adds a test that (trivially) checks to make sure that IsActive returns true for balancer pools. The primary purpose of this change is to make sure that if IsActive is ever used as an emergency switch, it is not accidentally left off for any or all pools.

I realize that my implementation has more structure than might seem necessary for a test this simple, but given how we intend to add more complex mock tests to cover IsActive flipping functionality in the future (#1904 (comment)), I figured setting it up properly the first time around might make it easier to implement these other tests later.

Brief Changelog

  • Add a test that makes sure IsActive always returns true

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
  • How is the feature or change documented? (not documented)

@AlpinYukseloglu AlpinYukseloglu added T:tests C:x/gamm Changes, features and bugs related to the gamm module. labels Jul 13, 2022
@mattverse mattverse merged commit 79e5708 into main Jul 13, 2022
@mattverse mattverse deleted the test-isactive branch July 13, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

x/gamm: Consider deleting IsActive and related checks
4 participants