Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/add release workflow to v10.x #2017

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

niccoloraspa
Copy link
Member

What is the purpose of the change

Backporting of #1644 to v10.x

Continues: #1550 

## What is the purpose of the change

This PR introduces an automatic release workflow via GitHub Actions to create all the artifacts for an osmosis release.
This workflow runs on every new tag or when manually triggered and it creates a release folder with all the osmosis binaries as workflow output.

## Brief Changelog

- Introduce automatic release workflow via GitHub Actions

## Testing and Verifying

Tested this workflow on a fork: https://github.com/nikever/osmosis/actions/runs/2422822418
The release folder is present in the `Artifacts` section:

![image](https://user-images.githubusercontent.com/6024049/171494127-37d1542c-7c4d-4690-ab6c-a43757b2295d.png)

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable
@niccoloraspa niccoloraspa requested a review from a team July 11, 2022 13:10
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a workflow need to be backported to a version branch? Aren't these ran off of main?

@niccoloraspa
Copy link
Member Author

Yep, you are right. The release.yml is not really needed. It was included in the commit that I cherry-picked.
I wanted to backport the fix of the typo in the Makefile, that's basically all I needed.

@p0mvn p0mvn merged commit 2c6aa5f into v10.x Jul 12, 2022
@p0mvn p0mvn deleted the backport/add-release-workflow branch July 12, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants