x/mint: make all fixtures in keeper package use KeeperTestSuite #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Jul 8, 2022
p0mvn
reviewed
Jul 8, 2022
p0mvn
approved these changes
Jul 8, 2022
Good to go now! |
p0mvn
approved these changes
Jul 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* only one test suite in mint module * Romans comments * roman comments v2 * romansv3 comments (cherry picked from commit 00e17c6) # Conflicts: # x/mint/keeper/grpc_query_test.go # x/mint/keeper/hooks_test.go
p0mvn
added a commit
that referenced
this pull request
Jul 19, 2022
p0mvn
added a commit
that referenced
this pull request
Jul 19, 2022
…port #2001) (#2152) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1920
What is the purpose of the change
Consolidate a single KeeperTestSuite with all the relevant set up code in suite_test.go in mint module. Make all test fixtures in keeper_test utilize this test suite.
Brief Changelog
n/a
Testing and Verifying
n/a
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (no)x/<module>/spec/) / Osmosis docs repo / not documented)