Refactor keeper tests in x/mint #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuong177
changed the title
p0mvn
requested changes
Jul 5, 2022
mattverse
reviewed
Jul 6, 2022
Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
p0mvn
reviewed
Jul 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* TestMintCoinsToFeeCollectorAndGetProportions refactor * TestDistrAssetToDeveloperRewardsAddrWhenNotEmpty refactor * add feePool and feeCollector check * comment * use hasPreExistingSupply and better readable mintKeeper * Update x/mint/keeper/keeper_test.go Co-authored-by: Matt, Park <[email protected]> * Update x/mint/keeper/keeper_test.go Co-authored-by: Matt, Park <[email protected]> * add testcase when nil dev reward address * use shorter keeper name for better readability Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit ed55aeb)
p0mvn
pushed a commit
that referenced
this pull request
Jul 19, 2022
* TestMintCoinsToFeeCollectorAndGetProportions refactor * TestDistrAssetToDeveloperRewardsAddrWhenNotEmpty refactor * add feePool and feeCollector check * comment * use hasPreExistingSupply and better readable mintKeeper * Update x/mint/keeper/keeper_test.go Co-authored-by: Matt, Park <[email protected]> * Update x/mint/keeper/keeper_test.go Co-authored-by: Matt, Park <[email protected]> * add testcase when nil dev reward address * use shorter keeper name for better readability Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit ed55aeb) Co-authored-by: vuong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1915
What is the purpose of the change
Brief Changelog
TestMintCoinsToFeeCollectorAndGetProportionsandTestDistrAssetToDeveloperRewardsAddrWhenNotEmptyTesting and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no