-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added section to Contributing.md detailing our desired pre-release code auditing process #1848
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1370357
chain json schema added
xBalbinus d459d90
sync
xBalbinus d7aaf99
Merge branch 'main' of https://github.com/osmosis-labs/osmosis
xBalbinus 98a2555
Merge branch 'main' of https://github.com/osmosis-labs/osmosis
xBalbinus 119e7b5
pre-release code-auditing process docs initialization
xBalbinus cf0ddc4
prerelease binary creation tool added
xBalbinus eb0e6e0
fixed a letter-typo in chain-schema
xBalbinus 7487db0
linked to v10 upgrade boilerplate, small phrasing changes
xBalbinus d41be17
md linter ifxes
xBalbinus 53bba6d
Update CONTRIBUTING.md
xBalbinus a01422a
Replaced gofmt section with just make-format
xBalbinus ffadbd9
Added resource for auto-formatting in Go
xBalbinus 0fb913d
Merge branch 'main' into xiangan/contributing
ValarDragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for trying it but are we actually going to test every changed message in e2e before a major release? Is this an achievable commitment in practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ValarDragon for thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think this requires an extra step of testing but I'm not sure on what your thoughts are on the potential significance of overhead in patches where lots of messages are added (rather, how often these happen). If it's not too significant then it may be do-able.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't feel the need to block the PR on this comment if that's what's happening. I'm just reading between the lines.
I think that the commitment to manually test every changed message on testnet is a must. My concern is only with respect to e2e. Please consider not mentioning it here.
At the moment, we don't have the capacity to test every changed message on the e2e testnet. So the commitment might not be realistic. We should be slowly moving towards that over time so that we can minimize manual testnet testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine to list for now - We need to make capacity for testing changed messages on testnet & work towards mitigating # of changes per release / making smaller releases more reasonable imo