Fix second source of (minor) over-LP shares #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
changed the title
alexanderbez
approved these changes
Jun 8, 2022
|
yeah we just need unit tests |
|
Working on unit tests and more comments here: #1721 |
|
I think we should merge this and review #1721 separately. What do you all think? |
|
Should #1723 be address in this PR as well? |
IMO, it's definitely a fix that we need but not with this PR since stableswap is a completely different component |
|
Going to add a changelog entry and merge. Unit tests are coming in:
|
p0mvn
approved these changes
Jun 9, 2022
alexanderbez
approved these changes
Jun 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
* Fix insufficient total share creation * More correctx * changelog entry Co-authored-by: Roman <[email protected]> (cherry picked from commit 089ce41)
alexanderbez
pushed a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Another bug, spotted by samczun. Not caught in tests, because it occurs on uneven swap amounts.
For uneven swap amounts, we tend to have tokens remaining after doing an equal ratio swap. For each of the tokens, we do a single asset pool join.
The logic was broken in providing the correct number fo shares for single asset joins. This PR fixes it.
This change added tests and can be verified as follows:
CalcJoinPoolShareswith uneven swap amounts: chore: additional test cases for TestCalcJoinPoolShares (multi-coin swap) #1713Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes