Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove "Why Osmosis" in main repo README #1690

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

AlpinYukseloglu
Copy link
Contributor

Closes: #1689

What is the purpose of the change

Temporarily remove "Why Osmosis" in main repo README. This section should be rewritten entirely later but in the meantime (especially going into Osmocon, which will likely generate some traffic for our main repo), it likely makes the most sense to just remove it temporarily.

Brief Changelog

  • Removed "Why Osmosis" section of main README

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@AlpinYukseloglu AlpinYukseloglu requested a review from a team June 6, 2022 15:27
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@ValarDragon ValarDragon merged commit e9a51cf into main Jun 6, 2022
@ValarDragon ValarDragon deleted the remove-why-osmosis branch June 6, 2022 16:40
vuong177 added a commit that referenced this pull request Jun 6, 2022
* refactor wasmbing

* refactor in wasmbinding/test

* change wasmbinding file path in simapp test

* README in wasmbinding

* minor

* remove Why Osmosis from README (#1690)

* Fix make format (#1693)

## What is the purpose of the change

Fixes `make format`, needed `mvdan.cc` added to tools directory.

## Brief Changelog

* Add mvdan.cc/gofumpt to tools folder
* Restrict it to only run on `app/ x/ ante/`, it has this annoying problem that it cannot run on the entire root folder because it reads the `.git` folder. It inherits the problem from `gofmt` that it cannot ignore a particular directory.

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? Should land into contributing.md once its here

* Delete unused simulator code (#1671)

* Delete unused simulator code

* Add hourly epochs to the x/epochs DefaultGenesis

* Add changelog

* Delete the unused x/gamm/simulation folder

* Fix epochs module tests for updated DefaultGenesis

* update CHANGELOG

* minor

Co-authored-by: alpo <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Temporarily remove "Why Osmosis" in main repo README
2 participants