Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the app interface #1665

Merged
merged 4 commits into from
Jun 5, 2022
Merged

Delete the app interface #1665

merged 4 commits into from
Jun 5, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Deletes the app interface. I have no idea what this is for, and am not familiar with other apps using it. If they are, this is an interface that should be defined in the SDK, that we than enforce compatability with here.

Brief Changelog

  • Delete App interface.

Testing and Verifying

Deadcode deletion

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team June 3, 2022 19:06
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Jun 3, 2022
@ValarDragon
Copy link
Member Author

Ah this came as an erroneous copy paste from: https://github.com/cosmos/cosmos-sdk/blob/main/simapp/types.go, so just need to change this interface to that.

@ValarDragon ValarDragon merged commit d77a311 into main Jun 5, 2022
@ValarDragon ValarDragon deleted the dev/delete_app_interface branch June 5, 2022 23:28
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant