Query osmo equivilent is staked via superfluid #1632
Conversation
proto/osmosis/superfluid/query.proto
Outdated
| @@ -70,6 +70,15 @@ service Query { | |||
| "superfluid_delegations/{delegator_address}"; | |||
| } | |||
|
|
|||
| // Returns all the superfluid poistions for a specific delegator | |||
| rpc SuperfluidOSMODelegationsByDelegator( | |||
There was a problem hiding this comment.
This is a mouthful haha. Any chance we can think of more abbreviated nomenclature.
There was a problem hiding this comment.
heee we can think of better names. How do u think about the logic
There was a problem hiding this comment.
I'm trying to understand what adding OSMO to the query means? I read the original issue and I don't understand why we can't augment the current query (SuperfluidDelegationsByDelegator)?
There was a problem hiding this comment.
@mattverse want to create a separate query (as i understant). Refer to #1539 (review)
There was a problem hiding this comment.
Should change to SuperfluidEquivilentDelegationsByDelegator?
proto/osmosis/superfluid/query.proto
Outdated
| @@ -187,6 +187,10 @@ message SuperfluidDelegationsByDelegatorResponse { | |||
| (gogoproto.nullable) = false, | |||
| (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | |||
| ]; | |||
| cosmos.base.v1beta1.Coin total_equivilent_staked_amount = 3 [ | |||
There was a problem hiding this comment.
| cosmos.base.v1beta1.Coin total_equivilent_staked_amount = 3 [ | |
| cosmos.base.v1beta1.Coin total_equivalent_staked_amount = 3 [ |
There was a problem hiding this comment.
thank u xD i changed that
x/superfluid/keeper/grpc_query.go
Outdated
| equivilentAmount := q.Keeper.GetSuperfluidOSMOTokens(ctx, baseDenom, lockedCoins.Amount) | ||
| coin := sdk.NewCoin(appparams.BaseCoinUnit, equivilentAmount) |
There was a problem hiding this comment.
| equivilentAmount := q.Keeper.GetSuperfluidOSMOTokens(ctx, baseDenom, lockedCoins.Amount) | |
| coin := sdk.NewCoin(appparams.BaseCoinUnit, equivilentAmount) | |
| equivalentAmount := q.Keeper.GetSuperfluidOSMOTokens(ctx, baseDenom, lockedCoins.Amount) | |
| coin := sdk.NewCoin(appparams.BaseCoinUnit, equivalentAmount) |
minor nit
docs/core/proto-docs.md
Outdated
| @@ -3691,6 +3692,7 @@ assets | |||
| | ----- | ---- | ----- | ----------- | | |||
| | `superfluid_delegation_records` | [SuperfluidDelegationRecord](#osmosis.superfluid.SuperfluidDelegationRecord) | repeated | | | |||
| | `total_delegated_coins` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated | | | |||
| | `total_equivilent_staked_amount` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | | | | |||
There was a problem hiding this comment.
I think this needs to be regenerated due to the typo
Thank u, i missed. Also added entry to changelog. |
* fix proto * get osmo equivilent is staked via superfluid * format * fix go_fmt * Revert "fix go_fmt" This reverts commit 5407105. * augment SuperfluidDelegationsByDelegator query * remove fmt * format * fix spell * fix spell, changelog * query (cherry picked from commit 19fedeb) # Conflicts: # x/superfluid/keeper/grpc_query.go
* Query osmo equivilent is staked via superfluid (#1632) * fix proto * get osmo equivilent is staked via superfluid * format * fix go_fmt * Revert "fix go_fmt" This reverts commit 5407105. * augment SuperfluidDelegationsByDelegator query * remove fmt * format * fix spell * fix spell, changelog * query (cherry picked from commit 19fedeb) # Conflicts: # x/superfluid/keeper/grpc_query.go * resolved * fix lint Co-authored-by: Hieu Vu <[email protected]>
Closes: #1525
What is the purpose of the change