Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete v043_temp directory #1630

Merged
merged 2 commits into from
May 31, 2022
Merged

Delete v043_temp directory #1630

merged 2 commits into from
May 31, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

This directory should have been deleted when we first moved to SDK v0.44.x, it was a pre-release copy of several future SDK utility modules.

Brief Changelog

  • Delete the v043_temp directory

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Compare the deleted module function to whats in the SDK: https://github.com/cosmos/cosmos-sdk/blob/main/types/address/hash.go#L63-L66

and https://github.com/cosmos/cosmos-sdk/blob/main/types/address/store_key.go#L8

(only API's from the module that we previously used)

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team May 31, 2022 12:20
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label May 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1630 (e79c865) into main (5492284) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   19.59%   19.50%   -0.09%     
==========================================
  Files         242      239       -3     
  Lines       32273    32225      -48     
==========================================
- Hits         6323     6287      -36     
+ Misses      24792    24784       -8     
+ Partials     1158     1154       -4     
Impacted Files Coverage Δ
x/gamm/types/pool.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5492284...e79c865. Read the comment docs.

@alexanderbez alexanderbez merged commit 8fe02f0 into main May 31, 2022
@alexanderbez alexanderbez deleted the dev/delete_tmp_dir branch May 31, 2022 13:33
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants