Add structs for Upgrades and Forks structs #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
- Coverage 19.82% 19.18% -0.64%
==========================================
Files 202 216 +14
Lines 27685 30693 +3008
==========================================
+ Hits 5489 5889 +400
- Misses 21175 23723 +2548
- Partials 1021 1081 +60
Continue to review full report at Codecov.
|
… into dev/upgrade_structs
p0mvn
approved these changes
May 3, 2022
| as is the case for all osmosis `Fork`s, then all logic changes must be height-gated or in the `BeginForkLogic` code. | ||
|
|
||
| ```go | ||
| type Upgrade struct { |
There was a problem hiding this comment.
nit: I think these code snippets are likely to go out of sync with the actual code overtime
There was a problem hiding this comment.
Hopefully they never update O_O
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1375
What is the purpose of the change
Simplifies a lot of the upgrades management logic / boilerplate. The goal is that every new upgrade should from the app.go level, just require a one line update. And all the complexity would otherwise be held to within each upgrades module.
This PR is marked as draft until Changelog update + docs update to the
app/upgradesREADME.Brief change log
Testing and Verifying
This should be covered by the existing test for the v4 upgrade, which tests that upgrade handler execution happens.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? Needs to be Donex/<module>/spec/) / Osmosis docs repo / not documented)