refactor: begin modularizing e2e tests in preparation for upgrade

[p0mvn]

Closes: #XXX

What is the purpose of the change

This is a spike related to #1235 to determine a test plan needed for implementing the upgrade.

Currently, there is no way to create genesis or configs such as app.toml for an older version of Osmosis because we directly depend on the branch that executes e2e tests. This is required to implement the logic for testing the upgrade.

This change decouples the functionality that directly depends on the Osmosis codebase from the e2e test runner by creating a chain package that is independent of the e2e package.

By decoupling the logic for configuring the chain (creating genesis + config files), we can use an older Docker image of the Osmosis codebase to configure the chains for the desired version. Then, we may use the created genesis and configs for the old version to execute the upgrade and perform e2e tests from the main branch.

Please note that this PR does not introduce any functional changes and only modularizes and decouples the code to make it possible to add the new upgrade functionality.

Brief change log

• create the chain package
• move some utility and io logic that is unrelated to the chain to util package
• move all remaining logic that is directly dependent on Osmosis codebase to chain package
• refactor chain package so that:
  • main.go - contains a single Init() function that initializes a chain with 2 validators
    • This function is called from the test setup in e2e package
  • chain.go and validator.go are mostly unchanged and only contain the implementations for Chain and Validator structs respectively
  • util.go is moved to chain/chain_util.go
  • config.go has constants and configuration logic
• refactor e2e_setup.go to have the following flow in setup:
  • create 2 chains by calling the chain.Init(<id>) method for each
    • the plan is to do this in a Docker container for a specific version of Osmosis in the future PR
  • configure Docker resources
  • run the 2 chains
  • run relayer

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

• run the e2e tests several times without issues

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? no
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
• How is the feature or change documented? not applicable - will be documented when the upgrade implementation is finalized

[codecov-commenter]

Codecov Report

Merging #1293 (e3622c2) into main (b6d342a) will decrease coverage by 0.75%.
The diff coverage is 9.32%.

@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   20.90%   20.14%   -0.76%     
==========================================
  Files         196      203       +7     
  Lines       25425    26824    +1399     
==========================================
+ Hits         5316     5405      +89     
- Misses      19118    20412    +1294     
- Partials      991     1007      +16     

Impacted Files	Coverage Δ
x/claim/abci.go	0.00% <ø> (ø)
x/claim/client/cli/query.go	34.45% <ø> (ø)
x/claim/client/cli/tx.go	0.00% <ø> (ø)
x/claim/handler.go	0.00% <ø> (ø)
x/claim/keeper/claim.go	64.33% <ø> (ø)
x/claim/keeper/grpc_query.go	2.50% <ø> (ø)
x/claim/keeper/hooks.go	28.00% <ø> (ø)
x/claim/keeper/keeper.go	87.50% <ø> (ø)
x/claim/keeper/params.go	81.81% <ø> (ø)
x/claim/module.go	58.06% <ø> (ø)
... and 106 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2029415...e3622c2. Read the comment docs.

[czarcas7ic]

Tested this locally as well and all prior tests still pass. Totally agree with pushing chain to a separate library. Great work!

I think the next step is figuring out what changes we need to make to the current osmosis docker image in order to facilitate these upgrade tests. After that, I think the next steps should be more straight forward.

[alexanderbez]

Looks like this just moved a few things around to isolate logic in packages with a few tweaks. LGTM.