Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9 RC Blocker] Disable Stableswap #1503

Closed
Tracked by #1511
czarcas7ic opened this issue May 16, 2022 · 2 comments · Fixed by #1523
Closed
Tracked by #1511

[v9 RC Blocker] Disable Stableswap #1503

czarcas7ic opened this issue May 16, 2022 · 2 comments · Fixed by #1523
Assignees
@mattverse

Comments

@czarcas7ic
Copy link
Member

Background

We need to comment out the stableswap instantiation in message services and any other present calls. This is a blocker for RC0 release of v9. This change should be competed by tomorrow, Tuesday May 17th.

Acceptance Criteria

  • stableswap is not instantiated in v9
  • all existing and new tests should pass
@daniel-farina daniel-farina moved this to Needs Review 🔍 in Osmosis Chain Development May 16, 2022
@czarcas7ic czarcas7ic changed the title [v9 Blocker] Disable Stableswap [v9 RC Blocker] Disable Stableswap May 16, 2022
@mattverse
Copy link
Member

Do we want to simply comment things out or do we want to completely remove them from implementation?

@czarcas7ic
Copy link
Member Author

Comment out IMO

@czarcas7ic czarcas7ic mentioned this issue May 16, 2022
Closed
14 tasks
@mattverse mattverse self-assigned this May 17, 2022
@mattverse mattverse mentioned this issue May 17, 2022
Merged
@mergify mergify bot closed this as completed in #1523 May 17, 2022
mergify bot pushed a commit that referenced this issue May 17, 2022
@mattverse
Disable Stableswap (#1523)
d3af599 
Closes: #1503 

## What is the purpose of the change

The upcoming V9 upgrade should be including the gamm generalization, but not stable swap implementations. 
This PR removes(comments out) stable swap inplementation and existing stableswap calls, which was to my surprise only present in `msg_sever.go` and `module.go`. 




## Brief Changelog
  - Remove stableswap implementation from gamm module
## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.


## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? (not applicable   /   specification (`x/<module>/spec/`)  /  [Osmosis docs repo](https://github.com/osmosis-labs/docs)   /   not documented)
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Stableswap osmosis-labs/osmosis
2 participants
@czarcas7ic @mattverse