Linear time improvements to epoch time (#517)

osmosis-labs · Oct 13, 2021 · dd1e4ee · dd1e4ee
1 parent fdaca2b
commit dd1e4ee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/x/incentives/keeper/gauge.go b/x/incentives/keeper/gauge.go
@@ -368,7 +368,8 @@ func (k Keeper) distributeInternal(
 			denomLockAmt := lock.Coins.AmountOfNoDenomValidation(gauge.DistributeTo.Denom)
 			amt := coin.Amount.Mul(denomLockAmt).Quo(lockSum.Mul(sdk.NewInt(int64(remainEpochs))))
 			if amt.IsPositive() {
-				distrCoins = distrCoins.Add(sdk.NewCoin(coin.Denom, amt))
+				newlyDistributedCoin := sdk.Coin{Denom: coin.Denom, Amount: amt}
+				distrCoins = distrCoins.Add(newlyDistributedCoin)
 			}
 		}
 		distrCoins = distrCoins.Sort()

diff --git a/x/lockup/types/lock.go b/x/lockup/types/lock.go
@@ -1,6 +1,7 @@
 package types
 
 import (
+	"fmt"
 	"time"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -24,8 +25,12 @@ func (p PeriodLock) IsUnlocking() bool {
 
 func SumLocksByDenom(locks []PeriodLock, denom string) sdk.Int {
 	sum := sdk.NewInt(0)
+	err := sdk.ValidateDenom(denom)
+	if err != nil {
+		panic(fmt.Errorf("invalid denom used internally: %s, %v", denom, err))
+	}
 	for _, lock := range locks {
-		sum = sum.Add(lock.Coins.AmountOf(denom))
+		sum = sum.Add(lock.Coins.AmountOfNoDenomValidation(denom))
 	}
 	return sum
 }