Skip to content

Commit

Permalink
CI: Delete failing step (#3124)
Browse files Browse the repository at this point in the history
* Delete failing step

* Fix int overflow in test logic
  • Loading branch information
ValarDragon authored Oct 24, 2022
1 parent df9102e commit 6274617
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 23 deletions.
20 changes: 0 additions & 20 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,7 @@ on:
workflow_dispatch:

jobs:
should_run_go_test:
runs-on: ubuntu-latest
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
steps:
-
id: skip_check
uses: fkirc/skip-duplicate-actions@master
with:
cancel_others: "true" # workflow-runs from outdated commits will be cancelled.
concurrent_skipping: "same_content"
skip_after_successful_duplicate: "true"
paths: '["**/*.go", "**/*.mod", "**/*.sum"]'
do_not_skip: '["pull_request", "workflow_dispatch", "schedule"]'
-
name: Skipping test
run: echo Should I skip tests? ${{ steps.skip_check.outputs.should_skip }}

go:
needs: should_run_go_test
if: ${{ needs.should_run_test.outputs.should_skip != 'true' }}
runs-on: ubuntu-latest
steps:
-
Expand Down
5 changes: 2 additions & 3 deletions x/gamm/pool-models/stableswap/amm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -483,13 +483,12 @@ func TestCFMMInvariantMultiAssetsDirect(t *testing.T) {
t.Run(name, func(t *testing.T) {
// system under test
sut := func() {
uReserve := calcUReserve(test.remReserves)
wSumSquares := calcWSumSquares(test.remReserves)

// using multi-asset cfmm
k2 := cfmmConstantMulti(test.xReserve, test.yReserve, uReserve, wSumSquares)
k2 := cfmmConstantMultiNoV(test.xReserve, test.yReserve, wSumSquares)
xOut2 := solveCFMMMultiDirect(test.xReserve, test.yReserve, wSumSquares, test.yIn)
k3 := cfmmConstantMulti(test.xReserve.Sub(xOut2), test.yReserve.Add(test.yIn), uReserve, wSumSquares)
k3 := cfmmConstantMultiNoV(test.xReserve.Sub(xOut2), test.yReserve.Add(test.yIn), wSumSquares)
osmomath.DecApproxEq(t, k2, k3, kErrTolerance)
}

Expand Down

0 comments on commit 6274617

Please sign in to comment.