forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: per module fast nodes #552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming we test this. We just need to infer some defaults in Osmosis perhaps?
I tested this on Osmosis mainnet with various whitelisted modules |
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* iavl v1 per module fast nodes * small logic change * initialize map * lint (cherry picked from commit 11b6186) # Conflicts: # baseapp/options.go # store/rootmulti/store.go # store/types/store.go
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* iavl v1 per module fast nodes * small logic change * initialize map * lint (cherry picked from commit 11b6186)
This was referenced Mar 8, 2024
czarcas7ic
added a commit
that referenced
this pull request
Mar 8, 2024
* iavl v1 per module fast nodes * small logic change * initialize map * lint (cherry picked from commit 11b6186) Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
added a commit
that referenced
this pull request
Mar 8, 2024
* feat: per module fast nodes (#552) * iavl v1 per module fast nodes * small logic change * initialize map * lint (cherry picked from commit 11b6186) # Conflicts: # baseapp/options.go # store/rootmulti/store.go # store/types/store.go * fix merge conflicts --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
added a commit
that referenced
this pull request
May 9, 2024
* iavl v1 per module fast nodes * small logic change * initialize map * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Adds app.toml option to whitelist modules to enable fast nodes for.
If fast nodes are enabled but there are modules listed in the whitelist, only the modules listed will have fast nodes enabled.