Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: per module fast nodes #552

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Mar 2, 2024

Description

Closes: #XXXX

Adds app.toml option to whitelist modules to enable fast nodes for.

If fast nodes are enabled but there are modules listed in the whitelist, only the modules listed will have fast nodes enabled.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we test this. We just need to infer some defaults in Osmosis perhaps?

@czarcas7ic
Copy link
Member Author

I tested this on Osmosis mainnet with various whitelisted modules

@czarcas7ic czarcas7ic merged commit 11b6186 into osmo/v0.47.5 Mar 8, 2024
23 checks passed
@czarcas7ic czarcas7ic deleted the adam/per-module-fast-nodes branch March 8, 2024 03:40
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
* iavl v1 per module fast nodes

* small logic change

* initialize map

* lint

(cherry picked from commit 11b6186)

# Conflicts:
#	baseapp/options.go
#	store/rootmulti/store.go
#	store/types/store.go
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
* iavl v1 per module fast nodes

* small logic change

* initialize map

* lint

(cherry picked from commit 11b6186)
czarcas7ic added a commit that referenced this pull request Mar 8, 2024
* iavl v1 per module fast nodes

* small logic change

* initialize map

* lint

(cherry picked from commit 11b6186)

Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Mar 8, 2024
* feat: per module fast nodes (#552)

* iavl v1 per module fast nodes

* small logic change

* initialize map

* lint

(cherry picked from commit 11b6186)

# Conflicts:
#	baseapp/options.go
#	store/rootmulti/store.go
#	store/types/store.go

* fix merge conflicts

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request May 9, 2024
* iavl v1 per module fast nodes

* small logic change

* initialize map

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants