Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: address snapshot/pruning refactor comments upstream #184

Merged
merged 46 commits into from
Apr 25, 2022
Merged

refactor: address snapshot/pruning refactor comments upstream #184

merged 46 commits into from
Apr 25, 2022

Commits on Apr 20, 2022

  1. address snapshot/pruning refactor upstream comments

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4bc6cbf View commit details
    Browse the repository at this point in the history

  2. add unit test for NewPruningOptionsFromString

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    2cea83c View commit details
    Browse the repository at this point in the history

  3. add TestLoadPruningHeights_PruneNothing

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9ee81eb View commit details
    Browse the repository at this point in the history

  4. remove db from LoadPruningHeights

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c0b8584 View commit details
    Browse the repository at this point in the history

  5. address previousHeight == 0 guard

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c61154d View commit details
    Browse the repository at this point in the history

  6. Update pruning/manager.go 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d9fc8bb View commit details
    Browse the repository at this point in the history

  7. fix snapshot height must be positive check

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ae14bf6 View commit details
    Browse the repository at this point in the history

  8. return 0 if negative previousVersion is given to the pruning manager.… 

    …HandleHeight, add unit tests
    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    b25ee58 View commit details
    Browse the repository at this point in the history

  9. resolve cherry-pick issue

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    35caf7c View commit details
    Browse the repository at this point in the history

  10. remove GetCommitKVStores

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    16ce576 View commit details
    Browse the repository at this point in the history

  11. avoid camel case in imports

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a90c180 View commit details
    Browse the repository at this point in the history

  12. remove type aliases from store types

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    92a42e2 View commit details
    Browse the repository at this point in the history

  13. revert pruning options pointer

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0cfcdf2 View commit details
    Browse the repository at this point in the history

  14. further remove type aliases from store types

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f694666 View commit details
    Browse the repository at this point in the history

  15. revert snapshot options pointer

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    dc72a60 View commit details
    Browse the repository at this point in the history

  16. clean up

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    5a9713d View commit details
    Browse the repository at this point in the history

  17. fmt

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d253b2d View commit details
    Browse the repository at this point in the history

  18. refactor: syncronize pruning manager (#187) 

    * progress

* refactor pruning manager to have no data races; flush heights immediately when updated in memory; unit tests

* typo in TestMultiStore_PruningRestart

* fmt

* improve comments

* avoid mutex init, move comments to struct declaration, return nil with error, fix logs
    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    cf64bc6 View commit details
    Browse the repository at this point in the history

  19. increase code coverage by covering panics in pruning manager unit tests

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0f41c95 View commit details
    Browse the repository at this point in the history

  20. increase coverage in pruning options

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e868f04 View commit details
    Browse the repository at this point in the history

  21. NegativeHeightsError implementation and format

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    29f02e2 View commit details
    Browse the repository at this point in the history

  22. Update pruning/README.md 

    Co-authored-by: Peter Bourgon <[email protected]>
    @p0mvn @peterbourgon
    p0mvn and peterbourgon committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    585e581 View commit details
    Browse the repository at this point in the history

  23. update order of declarations in pruning manager

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    83daeb3 View commit details
    Browse the repository at this point in the history

  24. new goroutine is handled by SnapshotIfApplicable caller

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8a4f74b View commit details
    Browse the repository at this point in the history

  25. synchronous SnapshotIfApplicable

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0bac1ba View commit details
    Browse the repository at this point in the history

  26. return a copy of pruneHeights in GetFlushAndResetPruningHeights

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0dba3ab View commit details
    Browse the repository at this point in the history

  27. godoc for pruning manager

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8108ecd View commit details
    Browse the repository at this point in the history

  28. Update error message in baseapp/baseapp.go 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    37f3270 View commit details
    Browse the repository at this point in the history

  29. sdk import in util_test.go

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8a854fe View commit details
    Browse the repository at this point in the history

  30. Apply suggestions from code review in pruning/README.md 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7ef157a View commit details
    Browse the repository at this point in the history

  31. Apply more style suggestions from code review 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c707b5d View commit details
    Browse the repository at this point in the history

  32. style fix in simapp/simd/cmd/root.go

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    b7f7e8e View commit details
    Browse the repository at this point in the history

  33. remove unused import in baseapp

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4ab0fdc View commit details
    Browse the repository at this point in the history

  34. update snapshots/README.md

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0002cc7 View commit details
    Browse the repository at this point in the history

  35. Update SnapshotIntervalOff comment in snapshots/types/options.go 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d8ca2fe View commit details
    Browse the repository at this point in the history

  36. Update pruneSnapshotHeightsKey pruning/manager.go 

    Co-authored-by: Aleksandr Bezobchuk <[email protected]>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    2d42509 View commit details
    Browse the repository at this point in the history

  37. update SetSnapshotInterval comment

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a929861 View commit details
    Browse the repository at this point in the history

  38. remove snapshot store type

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    096cee2 View commit details
    Browse the repository at this point in the history

  39. remove pruning and snapshot wrappers from store types

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    790e4f0 View commit details
    Browse the repository at this point in the history

  40. fix HandleHeight comment in pruning manager

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d261d42 View commit details
    Browse the repository at this point in the history

  41. snapshot happens in a separate goroutine

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a17cbec View commit details
    Browse the repository at this point in the history

  42. fix cherry-pick conflict

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d7224ad View commit details
    Browse the repository at this point in the history

  43. avoid returning custom pruning options from NewPruningOptions

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    29aa3b0 View commit details
    Browse the repository at this point in the history

  44. fix options_test.go

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    6d2ac52 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. set snapshot interval on multistore in baseapp instead of snapshot ma… 

    …nager
    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5b73cf4 View commit details
    Browse the repository at this point in the history

  2. fix snapshot manager unit tests

    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7e1219c View commit details
    Browse the repository at this point in the history