-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update TM dep + go.mod cleanup #175
Conversation
replace github.com/cosmos/iavl => github.com/osmosis-labs/iavl v0.17.3-osmo-v7 | ||
// latest grpc doesn't work with with our modified proto compiler, so we need to enforce | ||
// the following version across all dependencies. | ||
google.golang.org/grpc => google.golang.org/grpc v1.33.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we prefer grpc v1.33.2 instead of using google.golang.org/grpc v1.45.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm not aware of any reason. In fact, the SDK main
branch has v1.45.0
. We can update in a subsequent PR 👍
…into bez/bump-tm-sdk
This is blocked on another release which needs to include my fix: tendermint/tendermint#8270 |
(cherry picked from commit 772e828) # Conflicts: # go.mod
@Mergifyio backport v0.45.0x-osmo-v8 |
✅ Backports have been created
|
(cherry picked from commit 772e828) # Conflicts: # go.mod # go.sum
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change