Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TM dep + go.mod cleanup #175

Merged
merged 8 commits into from
Apr 8, 2022
Merged

Conversation

alexanderbez
Copy link

@alexanderbez alexanderbez commented Apr 5, 2022

Description

  • Update TM to v0.34.19
  • Cleanup go.mod
  • Update go 1.17

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez changed the title chore: update TM dep chore: update TM dep + go.mod cleanup Apr 5, 2022
@alexanderbez alexanderbez requested a review from mattverse April 5, 2022 17:57
replace github.com/cosmos/iavl => github.com/osmosis-labs/iavl v0.17.3-osmo-v7
// latest grpc doesn't work with with our modified proto compiler, so we need to enforce
// the following version across all dependencies.
google.golang.org/grpc => google.golang.org/grpc v1.33.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we prefer grpc v1.33.2 instead of using google.golang.org/grpc v1.45.0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm not aware of any reason. In fact, the SDK main branch has v1.45.0. We can update in a subsequent PR 👍

server/util.go Show resolved Hide resolved
@alexanderbez
Copy link
Author

This is blocked on another release which needs to include my fix: tendermint/tendermint#8270

@alexanderbez alexanderbez merged commit 772e828 into osmosis-main Apr 8, 2022
@alexanderbez alexanderbez deleted the bez/bump-tm-sdk branch April 8, 2022 13:16
mergify bot pushed a commit that referenced this pull request Apr 8, 2022
(cherry picked from commit 772e828)

# Conflicts:
#	go.mod
@alexanderbez
Copy link
Author

@Mergifyio backport v0.45.0x-osmo-v8

@mergify
Copy link

mergify bot commented Apr 15, 2022

backport v0.45.0x-osmo-v8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 15, 2022
(cherry picked from commit 772e828)

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants