fix: commit info data race #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
commented
Mar 25, 2022
| @@ -1022,36 +1043,17 @@ func getLatestVersion(db dbm.DB) int64 { | |||
| return latestVersion | |||
| } | |||
|
|
|||
| // Gets commitInfo from disk. | |||
| func getCommitInfo(db dbm.DB, ver int64) (*types.CommitInfo, error) { | |||
There was a problem hiding this comment.
Made a method and moved up
p0mvn
force-pushed
the
roman/commit-info-data-race
branch
from
948de1b
to
0b829c8
Compare
ValarDragon
approved these changes
Mar 26, 2022
|
|
||
| if err := batch.Write(); err != nil { | ||
| if err := batch.WriteSync(); err != nil { |
There was a problem hiding this comment.
Suggested change
| if err := batch.WriteSync(); err != nil { | |
| // We use WriteSync to ensure this get written to disk ASAP. | |
| if err := batch.WriteSync(); err != nil { |
| rs.flushLastCommitInfo(newCommitInfo) | ||
| } | ||
|
|
||
| func (rs *Store) flushLastCommitInfo(cInfo *types.CommitInfo) { |
There was a problem hiding this comment.
// should be called with rs.mx.Lock() taken
func (rs *Store) flushLastCommitInfo(cInfo *types.CommitInfo) {
This was referenced Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Commit(...)and read inQuery(...)andLastCommitID()rs.lastCommitInfoWriteSyncwhen flushing metadata since we want it to be immediately written to disk to avoid losing itRisks