Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document test dependencies #238

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Document test dependencies #238

merged 1 commit into from
Nov 20, 2023

Conversation

sebastic
Copy link
Contributor

The werkzeug dependency was not documented.

@lonvia
Copy link
Member

lonvia commented Nov 20, 2023

The new dependency is 'pytest-httpserver', which pulls in werkzeug. This is mentioned in the README but I forgot to add it to the release notes. Sorry about that.

I spend some time yesterday researching what is the approved way to specify test dependencies. Seems there is none. So I left it with the comment in README. Would it help packaging to have the extra-requires instead?

@sebastic
Copy link
Contributor Author

The new dependency is 'pytest-httpserver', which pulls in werkzeug.

test/test_replication.py imports werkzeug, hence the explicit dependency is required.

Would it help packaging to have the extra-requires instead?

Yes, it makes the test dependencies explicit just like a requirements-test.txt file would.

The werkzeug dependency was not documented.
@lonvia lonvia merged commit 49b7283 into osmcode:master Nov 20, 2023
20 checks passed
@sebastic sebastic deleted the patch-1 branch November 20, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants