Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added France #365

Merged
merged 3 commits into from
Feb 5, 2022
Merged

Added France #365

merged 3 commits into from
Feb 5, 2022

Conversation

llongour
Copy link
Contributor

@llongour llongour commented Feb 5, 2022

Hello
This PR adds France to the list of supported regions.

Many thanks for this great tool!

@jbelien jbelien added the region Add a new region label Feb 5, 2022
@jbelien jbelien merged commit 1865fb9 into osmbe:2.x Feb 5, 2022
@jbelien
Copy link
Member

jbelien commented Feb 5, 2022

Thanks!
It's deployed : https://welcome.osm.be/france/list 🚀

Data extraction is currently failing ; I'll check in the next few days (if it's not fixed).

@@ -53,6 +53,10 @@
<source>Democratic Republic of the Congo</source>
<target>剛果民主共和國</target>
</trans-unit>
<trans-unit id="ehyk73U" resname="France">
<source>France</source>
<target>法国</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Traditional Chinese (zh_TW) they use instead of

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry about this!
Could you submit a PR to update the correct translation of "France" in Traditional Chinese (zh_TW) ? Thanks a lot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you submit a PR

#396


* Même si nos outils d'édition essayent de rendre facile la cartographie des choses, notre [wiki](https://wiki.openstreetmap.org/wiki/) contient bien plus de détails, vous pourrez y trouver beaucoup d'informations sur la manière de cartographier.
Si vous voulez savoir comment "taguer" quelque chose, la solution la plus simple est probablement de chercher avec votre moteur de recherche favori comme ceci : `site:wiki.openstreetmap.org [terme à chercher]` ;
* Quand vous enregistrez vos modifications, ajoutez un commentaire court mais explicite sur ce que vous avez changé. ([Plus d'informations ici](https://wiki.openstreetmap.org/wiki/Good_changeset_comments)) ;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gendy54 , could you submit a PR to update the template ? Thanks!

jbelien pushed a commit that referenced this pull request Feb 7, 2022
@jbelien
Copy link
Member

jbelien commented Feb 13, 2022

Hello @l-longour, the extent of France (Metropolitan France + Overseas) seems to be too big for OSMCha API.

Could you split it in 2 separated regions ?
Thanks!

@LaoshuBaby
Copy link
Contributor

I make a experimental branch in our repository : https://github.com/OSMChina/osm-welcome-tool/tree/Help-France-community-fix-2-problem-mentioned

But I don't know France community's reaction, I also afraid that those maybe unproper.

(It looks like impolite to edit other countries' region file. So I don't want to make a initiative PR (If needed maintainer can make PR from downstream repository) and let this only a experimental branch)

@llongour
Copy link
Contributor Author

llongour commented Apr 1, 2022

Hello, thank you very much for your help, I only just noticed your new posts, I just looked at your repository @LaoshuBaby , I didn't see if the result reflected on the frontend would be a single element "France" or as many elements as the subdivision. If it is well unified on the frontend no problem, if not I will switch to metropolitan France and later add the overseas regions.

@LaoshuBaby
Copy link
Contributor

LaoshuBaby commented Apr 13, 2022

Hello, thank you very much for your help, I only just noticed your new posts, I just looked at your repository @LaoshuBaby , I didn't see if the result reflected on the frontend would be a single element "France" or as many elements as the subdivision. If it is well unified on the frontend no problem, if not I will switch to metropolitan France and later add the overseas regions.

@l-longour Thank you for reply me!

At that time I separated it to 4 regional geojson file:

assets/regions/france-atlanticocean.geojson
assets/regions/france-indianocean.geojson
assets/regions/france-metropolitan.geojson
assets/regions/france-pacificocean.geojson

I'm not a developer of welcome tool, but other community's mapper, so I don't know whether this separate is correct. (But at least you can choose the metropolitan file use). If current contribute way of welcome tool haven't change, according to https://github.com/osmbe/osm-welcome-tool/blob/2.x/CONTRIBUTING.md , one region , one osmcha.id.

@llongour llongour mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
region Add a new region
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants