Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the punctuation of the Polish welcome message #191

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Improve the punctuation of the Polish welcome message #191

merged 2 commits into from
Nov 29, 2021

Conversation

gszy
Copy link
Contributor

@gszy gszy commented Nov 26, 2021

Make use of Unicode characters like proper quotation marks, em dashes,
no‑break spaces and non‑breaking hyphens.

@gszy
Copy link
Contributor Author

gszy commented Nov 26, 2021

Cc: @RicoElectrico

@@ -1,28 +1,28 @@
---
name: Default
title: Witamy w OpenStreetMap
title: Witamy w OpenStreetMap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was changed here with this space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the normal ASCII space to the Unicode U+00A0 no‐break space. In Polish it is common to use this character after single letter conjunctions (“a”, “i”, “w”, etc., in some cases even after multi‐letter ones, like “na”) to prevent them from appearing at the end of the text line alone. That is, on a narrow screen, this would be preferred:

Witamy
w OpenStreetMap

over this:

Witamy w
OpenStreetMap

You may be unable to copy this character from GitHub web interface, since your web browser may silently replace it with a normal space.

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 28, 2021

Looks OK to me. Only this space changes seems weird to me.

@matkoniecz
Copy link
Contributor

Note: https://wiki.openstreetmap.org/wiki/ID_editor_walkthrough link can be replaced with https://wiki.openstreetmap.org/wiki/Pl:Samouczek_edytora_iD link - now available in Polish (in this PR or the next one)

@gszy gszy marked this pull request as draft November 28, 2021 19:53
gszy and others added 2 commits November 28, 2021 20:59
Make use of Unicode characters like proper quotation marks, em dashes,
no‑break spaces and non‑breaking hyphens.
@gszy gszy marked this pull request as ready for review November 28, 2021 20:04
@jbelien jbelien added the template Add new template label Nov 29, 2021
@jbelien jbelien added this to the Version 2.2 milestone Nov 29, 2021
@jbelien jbelien merged commit d633281 into osmbe:2.x Nov 29, 2021
@gszy gszy deleted the polish branch December 1, 2021 11:47
@RicoElectrico
Copy link
Contributor

Thanks @gszy @matkoniecz - do you have any suggestion of a plain text editor that helps use nbsp and typographical punctuation?

@matkoniecz
Copy link
Contributor

matkoniecz commented Dec 2, 2021

No idea. Usually I ignore both and rather take steps to disable typographical support. One of first things that I do with a text editor configuration is to keep them from replacing - with dashes and em-dashes etc.

@gszy
Copy link
Contributor Author

gszy commented Dec 2, 2021

do you have any suggestion of a plain text editor that helps use nbsp

Anything KTextEditor‐based as well as Neovim seem to highlight them by default:

kwrite

neovim

gedit highlights nbsps in a special way if highlighting of all spaces is enabled:

gedit

mcedit shows the character code in top right (160 or 0xA0 in this case):

mcedit

and typographical punctuation?

I think this one depends on your font, for example in Hack U+002D hyphen-minus, U+2010 hyphen, U+2013 en dash, U+2014 em dash all have distinct shapes, though only the last one is really easy to recognize at small font size.

An en/em dash as well as an nbsp are quite easy to type on the default Polish Linux keyboard.

replacing - with dashes and em-dashes etc.

I wouldn’t call it a nice feature for a plain text editor on a general purpose operating system…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template Add new template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants