Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovenia #1256

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Add Slovenia #1256

merged 6 commits into from
Nov 23, 2023

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Nov 12, 2023

No description provided.

config/regions.yaml Outdated Show resolved Hide resolved
@jbelien jbelien added the region Add a new region label Nov 12, 2023
@jbelien
Copy link
Member

jbelien commented Nov 12, 2023

Thanks a lot @stefanb ! I'll take care of the last steps in the next few days 👍

@jbelien
Copy link
Member

jbelien commented Nov 20, 2023

@stefanb Everything is ready but I need the permission to write in your repository to be able to finish the last steps.

@stefanb
Copy link
Contributor Author

stefanb commented Nov 20, 2023

@jbelien, if you have the write access to this repository you should also have the write permission on this PR's branch in my fork. Have you tried it?

@jbelien
Copy link
Member

jbelien commented Nov 23, 2023

@jbelien, if you have the write access to this repository you should also have the write permission on this PR's branch in my fork. Have you tried it?

No, sorry that's incorrect.
This PR is based on https://github.com/openstreetmap-si/osm-welcome-tool/tree/add-slovenia branch ; I need write permission on that repository to push my changes.

@stefanb
Copy link
Contributor Author

stefanb commented Nov 23, 2023

Ah, yes, I forgot the detail that it wasn't my personal fork. I have sent you the collaborator invite in that fork.

@jbelien jbelien merged commit 11476e9 into osmbe:2.x Nov 23, 2023
9 checks passed
@jbelien
Copy link
Member

jbelien commented Nov 23, 2023

🚀 Deployed: https://welcome.osm.be/europe/slovenia/list

List will be automatically updated tomorrow!

@stefanb
Copy link
Contributor Author

stefanb commented Nov 24, 2023

Thanks, @jbelien !

@stefanb stefanb deleted the add-slovenia branch November 24, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
region Add a new region
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants