feat(china-heilongjiang): Add province in China #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create china-heilongjiang.geojson
Update and rename config/regions.yaml to 配置/regions.yaml
Also change new region's order
Yes, please I need to finalize this PR. |
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this time we want to add a new province in China which named Heilongjiang. Another mapper created #1033 and #1034 but looks like something went wrong, I've fixed it. We've insert this new region to
region.yamland attach a geojson file, copy message template and copy translation.osmcha.idin region.yaml and id intrans-unitleft blank because I don't know how to generate it properly. Shall I add a repositoory access so that you can modify them directly?