Improve handling addr:place without a place node #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Housenumbers with unlisted place names should be handled like any ither housenumbers with missing address terms.
This is now needed to weigh results.
lonvia
force-pushed
the
improve-handling-unlisted-places
branch
from
5ab3881
to
7fb3ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an address point has its own entry in the search_name table, then the tokens for addr:place must always go into the address token list. Everything else causes false matches.
Also adds full terms for addr:* items to the search_name table. They used to be irrelevant but are needed these days because we rerank by full-term matches.
Fixes #3208.