admin --check-database also checks database vs nominatim version

[mtmail]

Should the test run before other tests or later? I think the hints should give instruction for lower database version or lower nominatim version.

nominatim admin --check-database
2023-11-02 15:12:55: Using project directory: /home/vagrant/nominatim-project
2023-11-02 15:12:55: Checking database
Checking database connection ... OK
Checking database_version matches Nominatim software version ... Failed
Database version (4.3.0-0) doesn't match Nominatim version (4.1.0-0)

Hints:
* Are you connecting to the right database?
* Have you run all migrations?

Project directory: /home/vagrant/nominatim-project
Current setting of NOMINATIM_DATABASE_DSN: pgsql:dbname=nominatim

[lonvia]

That's the right place to run it.

The hints should definitely distinguish between db_version < nominatim_version ("Please migrate") and vice versa ("You must not run an older Nominatim on a newer database. Upgrade your software.")

[lonvia]

Can you please rebase on master? That will solve the CI fails.

[mtmail]

@lonvia Rebased now and indeed tests are passing.