Add support for SQLite DBs in frontend: reverse #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all information not strictly used by the frontend as well as any index information. This will make it easier to create a SQLite database from the schema.
Includes porting unit tests.
The database must currently be created by hand and the name handed in via -DAPI_TEST_DB='sqlite:...'.
Transfer is_address_point into SQLAlchemy function, so that json.has_key() can use the older json_extract() function. And work around broken Distance function.
A boolean type makes the SQLite dialect produce a costruct like 'func() = 1' in WHERE condition. While syntactically correct, it tends to confuse the query planer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of enabling Nominatim to be run from a SQLite (or rather SpatialLite) database.
The major changes are:
nominatim convertto dump an existing PostGIS database into an SQLite file,CI does run the unit tests for SQLite but not the BDD tests.
SQLite support is highly experimental and currently undocumented. To try it out, use the new convert function to create a databse. Then set the database DSN to
sqlite:dbname=<filename>to use it. It also works with the web frontend andnominatim servewhen using one of the Python engines.Differences between PostgreSQL and SQLite are hidden behind custom SQLAlchemy functions, so the code should not interfere with normal operations. If other interference shows up in production, I reserve the right to pull the code out again.