-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wide popups usually half off-screen #507
Comments
Max width is already implemented, but does not work. https://github.com/osm-fr/osmose-frontend/blob/master/web/static/map/Osmose.Marker.ts#L24 |
Just a stupid suggestion, but in the defaults I see a unit is specified (https://github.com/maplibre/maplibre-gl-js/blob/0b4688b5c34bfa4dab4e956d0e67d2703bd1ec95/src/ui/popup.ts#L20) while in Osmose it isn't. |
Good catch! I miss this point when I look at this before. |
Fixed. Thank you. |
For very wide popups, you (usually) don't see the full popup.
When opening it it's dependent on the map, but after dragging the map a little bit, it is always half.
Example here
Either it looks like this:
Or like this:
Occasionally I get it like this, which isn't perfect either, but at least 90% is visible:
Ideally, it would limit the popup width to for instance 50% of the "map region" width, either by word-wrapping the text if it's too long, or having a horizontal scroll bar for the tags.
The text was updated successfully, but these errors were encountered: