[WIP] Integration of radio supports #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodrigo
reviewed
Sep 2, 2019
|
The subclass and the JSON mapping file are two ways to achieve the same thing. It bothers me to mix them. |
pyrog
reviewed
Sep 9, 2019
| static2 = {"source": self.source}, | ||
| mapping1 = { | ||
| "ref:FR:ANFR": "SUP_ID", | ||
| "owner": lambda fields: self.proprietaire[int(fields["TPO_ID"])] if fields["TPO_ID"] and int(fields["TPO_ID"]) in self.proprietaire else None, |
There was a problem hiding this comment.
Pour rester cohérent avec le preset Communication Towers de JOSM, il faudrait utiliser la clé operator à la place de owner.
Voir aussi man_made=tower sur le wiki.
pyrog
reviewed
Sep 9, 2019
| #23 : Phares et balises, | ||
| 24 : u"SNCF Réseau", | ||
| 25 : u"RTE", | ||
| #26 : SDIS, secours, incendie, |
There was a problem hiding this comment.
On peut proposer SDIS (même si en pratique c'est par exemple SDIS 39 pour le Jura).
There was a problem hiding this comment.
le probleme c'est que c'est "SDIS, secours, incendie" donc pas forcement SDIS.
There was a problem hiding this comment.
Bien vu 😄, à mettre donc dans text pour que le contributeur saisisse la bonne valeur.
frodrigo
changed the title
|
Ping me if you have question, or when you are ready. |
|
Replaced by #622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#538