Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple_tag_lang_fr triggered on bus stops with name containing "Marché" #586

Closed
treinen opened this issue Aug 14, 2019 · 2 comments
Closed

Comments

@treinen
Copy link
Contributor

treinen commented Aug 14, 2019

source = 408828
item = 3032
class = 3032
subclass = 5
elems = node2880104587

When the name of a public_transport item (for instance a bus stop) contains the word "Marché" then osmose demands to add amenity=marketplace.

Qick patch (untested):

--- a/plugins/TagFix_MultipleTag_Lang_fr.py
+++ b/plugins/TagFix_MultipleTag_Lang_fr.py
@@ -50,7 +50,7 @@ class TagFix_MultipleTag_Lang_fr(Plugin):
                 if self.Eglise.match(tags["name"]) and not self.EgliseNot1.match(tags["name"]) and not self.EgliseNot2.match(tags["name"]):
                     err.append({"class": 3032, "subclass": 1, "text": T_(u"\"name=%s\" is the localisation but not the name", tags["name"])})
         else:
-            if "shop" not in tags and self.Marche.match(tags["name"]):
+            if "shop" not in tags and "public_transport" not in tags and self.Marche.match(tags["name"]):
                 err.append({"class": 3032, "subclass": 5, "fix": {"amenity": "marketplace"}})
 
         if "historic" in tags:
@frodrigo
Copy link
Member

Ok. I take the patch.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Aug 16, 2019
jocelynj added a commit that referenced this issue Aug 19, 2019
* frodrigo/master: (27 commits)
  Workaround Geofabrik 404
  Geocoding fallback to Merimee coord on analyser_merge_heritage_FR_merimee #591
  Better geocoding in analyser_merge_heritage_FR_merimee #591
  Update fields names in analyser_merge_power_plant_FR
  Deduplicate official data in Analyser_Merge #560
  Avoid duplicate issues in TagWatchFrViPofm #560
  Avoid duplicate issiues in Name_MisspelledWordByRegex_Lang_fa.validator.mapcss #560
  Avoid duplicate issues in analyser_osmosis_highway_zone #560
  Avoid duplicate issues in analyser_osmosis_relation_enforcement #560
  Avoid duplicate issues in analyser_osmosis_relation_restriction #560
  Avoid duplicate issues in analyser_osmosis_roundabout_level #560
  No issue on bus stops with name containing 'Marché' in TagFix_MultipleTag_Lang_fr #586
  Avoid duplicate issue from analyser_osmosis_boundary_relation #560
  Fix avoid duplicate issues in analyser_osmosis_node_like_way #560
  Avoid duplicate issues in analyser_osmosis_relation_associatedStreet #560
  Avoir duplicate in analyser_osmosis_addr_interpolation (and speed up) #560
  Avoid duplicate issue in Highway_Lanes #560
  Only one fix per tag in analyser_osmosis_tag_typo #560
  Avoid duplicate issues from Name_Script #560
  Use highway_ends.geom in analyser_osmosis_highway_cul-de-sac_level
  ...
@frodrigo
Copy link
Member

Done. Update in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants