Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in tag for static_caravans #574

Closed
danfos opened this issue Jul 28, 2019 · 4 comments
Closed

Typo in tag for static_caravans #574

danfos opened this issue Jul 28, 2019 · 4 comments
Labels
bug ready

Comments

@danfos
Copy link
Contributor

danfos commented Jul 28, 2019

I see that Osmose is reporting a Typo in tag for static_caravans with the suggestion to change it to static_caravan (without an 's')

For an example see http://osmose.openstreetmap.fr/en/map/#item=3150&zoom=16&lat=51.90498&lon=4.17745&level=1&tags=&fixable=

The camp site page indicates static_caravans just like tents, caravans and cabins. Tag info is shows both values are used but for static_caravan almost all have the value "plot", not sure what this means but no good reason to report "Typo in tag" I think.

What is strange is that I do not see a "Typo in tag" problem reported for the Idéal Camping while that has also "static_caravans=yes"
@frodrigo
Copy link
Member

cc @Marc-marc-marc

@Marc-marc-marc
Copy link
Contributor

static_caravan=plot : all from the same user in Holland, without being in a tourism=camp_site nor in a tourism=caravan_site : so no idea of the meaning. perhaps this means that this cadastral parcel is occupied by a static caravan. I asked the contributor the question.
66 of 67 static_caravans are combined with a tourism=, the last on with a wrong leisure=camp_site.
all other types of tourism= parcels (like tents cabins caravans) are words in the plural, so it seems better to not report the plural as an error. this is a point that could be discussed in the current proposal to fine-tune the parcels tags

@frodrigo
Copy link
Member

TODO

  • white list static_caravans and static_caravan

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Aug 3, 2019
@frodrigo
With list static_caravans and static_caravan in analyser_osmosis_tag_…
ba570ac 
…typo osm-fr#574
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Aug 7, 2019
@frodrigo
With list static_caravans and static_caravan in analyser_osmosis_tag_…
3d7763e 
…typo osm-fr#574
jocelynj added a commit that referenced this issue Aug 7, 2019
@jocelynj
Merge remote-tracking branch 'frodrigo/master'
853d2e5 
* frodrigo/master:
  With list loc_ref and lock_ref in analyser_osmosis_tag_typo #581
  Add name as subtile in Name_Initials #580
  With list static_caravans and static_caravan in analyser_osmosis_tag_typo #574
  Add mot tags to match in shop_FR.mapping.json #338
  Avoid issues on relation less geom into analyser_osmosis_boundary_relation
@frodrigo
Copy link
Member

frodrigo commented Aug 8, 2019

Done. Data update on going.

@frodrigo frodrigo closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frodrigo @danfos @Marc-marc-marc