Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding club=* as a main tag for class 21101 #550

Closed
hgcvm opened this issue Jul 5, 2019 · 2 comments
Closed

Consider adding club=* as a main tag for class 21101 #550

hgcvm opened this issue Jul 5, 2019 · 2 comments
Labels
bug ready

Comments

@hgcvm
Copy link

hgcvm commented Jul 5, 2019

As stated in the wiki: https://wiki.openstreetmap.org/wiki/Key:club

club=* can stand on its own just like shop=/office=/craft=*.

In 21101, we check if there is a name, and if so, there should also be present a "main tag".

My own amateur research showed me that in the file "osmose-backend/plugins/TagFix_MultipleTag.py", line 52, the "main tags" are summed up.

Could we add club to that list?
@frodrigo
Copy link
Member

frodrigo commented Jul 5, 2019

Even if the tag is not really used. It is an approved tags.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jul 5, 2019
@frodrigo
Add club as main tag in TagFix_MultipleTag osm-fr#550
27c70bc
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jul 8, 2019
@frodrigo
Add club as main tag in TagFix_MultipleTag osm-fr#550
627d66d
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jul 8, 2019
@frodrigo
Add club as main tag in TagFix_MultipleTag osm-fr#550
a51a63d
jocelynj added a commit that referenced this issue Jul 8, 2019
@jocelynj
Merge remote-tracking branch 'frodrigo/master'
d47fadd 
* frodrigo/master:
  Use name:left and name:right & better relation location in analyser_osmosis_relation_associatedStreet #551
  White list amenity=stables + leisure=horse_riding in TagRemove_Incompatibles #553
  Active Phone plugin for Cuba
  Fix Phone for Spain #546
  Update plugin Phone Spain
  Add club as main tag in TagFix_MultipleTag #550
  Handle construction=minor in Construction2.validator.mapcss #545
  Remove hospital/doctors in shop_FR.mapping.json #338
  In analyser_merge_shop_FR also filter on trancheEffectifs #338
  shop_FR.mapping.json replace note=FIXME by fixme= #338
  Exclude Appartements and "chez" in analyser_merge_shop_FR #338
  Revert change on ST_DistanceSphere analyser_osmosis_water #448
  mapcss: regen from mapcss
  mapcss: fix test code generation
  mapcss: skip area selector
@frodrigo
Copy link
Member

frodrigo commented Jul 9, 2019

Done.

@frodrigo frodrigo closed this as completed Jul 9, 2019
@hgcvm hgcvm mentioned this issue Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frodrigo @hgcvm