Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Street object, also match amenity=bicycle_parking with ways #523

Closed
AnkEric opened this issue Jun 4, 2019 · 9 comments
Closed

Street object, also match amenity=bicycle_parking with ways #523

AnkEric opened this issue Jun 4, 2019 · 9 comments

Comments

@AnkEric
Copy link

AnkEric commented Jun 4, 2019

Osmose: amenity=bicycle_parking Street object bicycle parking observed around but not associated tags

IMO: associated tags have been set correctly.

Sample: http://osmose.openstreetmap.fr/en/error/27579621715

OSM tags:

  • way (15 meters)
  • amenity=bicycle_parking
  • bicycle_parking=stands
  • capacity=20

Perhaps Osmose is expecting a node or an area?
I agree, this would be better. But I'm lazy and 12x (?) node or drawing an uncertain area is too much work (for me).
Or: node (or way) is "Quick and Dirty" and should be updated as an area as soon as possible?

OSM WIKI:

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbicycle_parking
amenity=bicycle_parking:

- may be used on nodes
- may be used on ways
- may be used on areas

For now, please ignore my other issue (OFF TOPIC):
Mapillary "Street object ****" is responsible for too many false positives.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jun 4, 2019
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jun 4, 2019
@AnkEric
Copy link
Author

AnkEric commented Jun 5, 2019

I did find two other examples:

http://osmose.openstreetmap.fr/en/error/27612376518
[amenity=bicycle_parking] as 2x Node

http://osmose.openstreetmap.fr/en/error/27612376540
[amenity=bicycle_parking] as Area

Both are reported as missing tags...

@frodrigo
Copy link
Member

frodrigo commented Jun 5, 2019

The fix is already on the way and deployed soon.
frodrigo@51404d6

@AnkEric
Copy link
Author

AnkEric commented Jun 5, 2019

Oké, I will wait and watch...

But also, the fix to be deployed is: "enable ways".
These examples are about Nodes and Areas.

Perhaps distance is also relevant?
As compared to "Tag "addr:street" not matching a street name around"?
"not around" implies a house is 50 meters away from street and no highway is mapped for access, or highway=service does not have a name set...
These are [amenity=bicycle_parking] not connected to any highway... (+ ???)

@frodrigo
Copy link
Member

frodrigo commented Jun 5, 2019

But also, the fix to be deployed is: "enable ways".
These examples are about Nodes and Areas.

Ways and areas are the the OSM data schema. Here the distance is 30m, can be changed.

Tag "addr:street" not matching a street name around"

Distance is 2000m (5000m in CA et NZ)

@AnkEric
Copy link
Author

AnkEric commented Jun 5, 2019

Here the distance is 30m, can be changed.

Which distance are you referring to?
The distance between [Mapillary image location] and Area [amenity = bicycle_parking] is a minimum of 6 meters, a maximum of 20 meters.
See virtual way having a length of 10 meters (just to show distance).

Who should "change" the distance of 30m ?

Osmose? Osmose should be less restrictive ??

Or should I move [amenity=bicycle_parking] closer to [highway=cycleway] ???
Would be oké, now I see a "Missing access way to parking" (not applicable to bicycle_parking however).
Connect [amenity=bicycle_parking] and [highway=cycleway] (giving access) ???

Or should I move [amenity=bicycle_parking] closer to [Mapillary image] location ????
IMO: [Mapillary image] location is not relevant. I have seen images showing a bicycle_parking on more than 30 meters distance. Just because image location is not on bicycle_parking location. I must have been cycling too fast; -))

image

jocelynj added a commit that referenced this issue Jun 5, 2019
* frodrigo/master:
  Enable ways for bicycle_parking in mapillary-street-objects.mapping.json #523
  Fix TagRemove_Fixme #520
  White list CRAIG - IGN - TopoGEODIS #521
  Fix shop_FR.mapping.csv
@frodrigo frodrigo changed the title Unjustified (?) Error (?): amenity=bicycle_parking Street object bicycle parking observed around but not associated tags Street object, also match amenity=bicycle_parking with ways Jun 6, 2019
@frodrigo
Copy link
Member

frodrigo commented Jun 7, 2019

Can you confirm it's now OK about the detection of amenity=bicycle_parking on ways ?

@AnkEric
Copy link
Author

AnkEric commented Jun 7, 2019

I have verified my three examples:

A bit OT: a way (line) is often NOT Rendered as POI.
NOT on: https://www.openstreetmap.org/#map=19/52.08456/4.88825
NOT on: OpenFietsMap, OsmAnd, my "own" Map
But if OSM-WIKI approves this is a Renderers Error (IMO).
So: Osmose is first to detect a POI tagged as Way! Good! But also: minority view ?!

More OT, this is (IMO) a dilemma:
Yesterday I changed [tourism=artwork] on a Node connected to footway into a Way.
Today I verified this tagging not to be rendered and reverted into 2x node.
https://www.mapillary.com/map/im/UiuW7-l8Wy17gX8sP2UFpw
I'm curious as to your opinion on this Changeset:
https://www.openstreetmap.org/changeset/71018361

Also "on the ground": 20 meters of one picnic_table.
https://www.mapillary.com/map/im/60a2A6AHTt1AATvUNoap2g
1x Way ?
7x Node ??
1x Node + [length=20] ???
1x Area ????

Same applies to [barrier=*], except for [barrier=fence, guard_rail, wall].

OSM only (?) acknowledges [natural=tree_row] and [highway=parking_aisle] !

@frodrigo
Copy link
Member

frodrigo commented Jun 10, 2019

For the not found amenity=bicycle_parking, I found a bug in the matching computation.
Should increase the bbox of tested object by the matching distance.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jun 10, 2019
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jun 17, 2019
jocelynj added a commit that referenced this issue Jun 17, 2019
* frodrigo/master:
  Fix config of country in Name_UpperCase
  Ignore camp_type/lamp_type in analyser_osmosis_tag_typo #534
  Ignore Inventaire in analyser_merge_heritage_FR_merimee #517
  Better select in analyser_merge_shop_FR & move mapping to json #338
  Fuzzy geocoding results at municipality level in analyser_merge_power_plant_FR #510
  Fix bbox size in Analyser_Merge #523
  Fix logger param in Analyser_Merge / Analyser_Merge_Mapillary
@frodrigo
Copy link
Member

Now it's OK.

Reopen dedicated issue to other subject if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants