Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive : Tag "addr:street" not matching a street name around #518

Closed
bilboed opened this issue May 27, 2019 · 1 comment
Closed

Comments

@bilboed
Copy link
Contributor

bilboed commented May 27, 2019

This issue happens for all addresses on squares/plazas/... which are highways tagged with area=yes.

For example this plaza in Montpellier : http://osmose.openstreetmap.fr/en/map/#zoom=18&lat=43.599254&lon=3.897137&item=2060

My understanding is that this false-positive is because anything with area=yes gets excluded from the "highways" DB in Analyser_Osmosis.py , meaning that the later Analyser_Osmosis_Relation_AssociatedStreet can't match the addr:street against anything.

The problem is that the historical way to mark pedestrian squares was to use highway=pedestrian, area=yes ... meaning that all addresses on that square will be marked as false positives.

While excluding "area" highways makes sense, would it make sense to also allow (whether area or not), the highways with place=square in the ways DB of Analyser_Osmosis.py ? Or would that be too disruptive and instead add that additional check in Analyser_Osmosis_Relation_AssociatedStreet ?

@frodrigo frodrigo added the bug label Jun 1, 2019
@frodrigo frodrigo added the ready label Jun 19, 2019
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jun 22, 2019
jocelynj added a commit that referenced this issue Jun 23, 2019
* frodrigo/master:
  Update mapcss parser to support new operators
  Clean unussed split in analyser_osmosis_highway_floating_islands
  Revert to full linestring to avoid false positive in analyser_osmosis_highway_floating_islands #541
  Clean code in analysers/analyser_osmosis_highway_floating_islands
  Also support natural=water + water=fjord|harbour in analyser_osmosis_water #448
  Restrict analyser_osmosis_soundex to latin script #525
  Generalize merge_shop_FR in France #338
  Include construction in factorized table highway #514 #506
  Support area in factorized osmosis table highway #518
  Merge shop within 20m #338
@frodrigo
Copy link
Member

It's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants