Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit oneway arrows to currently supported highway features #972

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

claysmalley
Copy link
Member

@claysmalley claysmalley commented Oct 21, 2023

Currently, oneway arrows appear on railroads in Americana. oneway=yes on railway=* is a tagging error mistakenly exposed on OpenMapTiles, and railway:preferred_direction=forward|backward is the correct tag for a track on which trains only travel in one direction in most circumstances. This PR limits oneway arrows to highway features, preventing them from showing up on railroads.

production, preview, localhost

before:
image

after:
image

@claysmalley claysmalley added bug Something isn't working highway-lines labels Oct 21, 2023
@claysmalley claysmalley marked this pull request as ready for review October 21, 2023 16:22
@ZeLonewolf
Copy link
Member

Is there a corresponding ticket in OMT that should be opened?

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree with being explicit about the classes with oneway treatment. Once we have finer control over the tile schema, we might de-optimize that check and handle this on the tile side. The layer size increase is not significant (~400 bytes).

@claysmalley claysmalley merged commit 9be18eb into main Oct 24, 2023
2 of 3 checks passed
@claysmalley claysmalley deleted the clay-oneway-filter branch October 24, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working highway-lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants