Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shields for Great Lakes Circle Tour routes #752

Merged
merged 9 commits into from
Feb 1, 2023
Merged

Add shields for Great Lakes Circle Tour routes #752

merged 9 commits into from
Feb 1, 2023

Conversation

quincylvania
Copy link
Contributor

Closes #569. The Lake Erie one is kinda busy but then again, so is the road sign. The other three I'm pretty happy with but I welcome feedback on all of this.

shield_us_glct_lhct
shield_us_glct_lmct
shield_us_glct_lsct
shield_glct_lect

Screenshot 2023-01-31 at 9 10 21 PM

Screenshot 2023-01-31 at 9 10 08 PM

Screenshot 2023-01-31 at 9 11 39 PM

Screenshot 2023-01-31 at 9 12 11 PM

Screenshot 2023-01-31 at 9 10 47 PM

Screenshot 2023-01-31 at 9 18 30 PM

Screenshot 2023-01-31 at 9 43 03 PM

Screenshot 2023-01-31 at 9 42 52 PM

Screenshot 2023-01-31 at 9 42 38 PM

1ec5
1ec5 reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The graphics look great on my 2× display. Perhaps those with 1× displays could try this out and see if the designs work well enough at a lower pixel density.

CONTRIBUTING.md Outdated Show resolved Hide resolved
src/js/shield_defs.js Outdated Show resolved Hide resolved
src/js/shield_defs.js Outdated Show resolved Hide resolved
icons/shield_glct_lhct.svg Outdated Show resolved Hide resolved
icons/shield_glct_lhct.svg Outdated Show resolved Hide resolved
@claysmalley
Copy link
Member

Looking good at 100% zoom:

Screenshot from 2023-02-01 09-23-30
Screenshot from 2023-02-01 09-25-42
Screenshot from 2023-02-01 09-26-46

@quincylvania
Copy link
Contributor Author

quincylvania commented Feb 1, 2023 •
edited
Loading

I added the Loop route for Lake Michigan. I can add more variants once when further mapping of these is done.

Screenshot 2023-02-01 at 10 45 11 AM

I also removed the light beams from the Lake Erie shield since I found them distracting. If people liked the other one better I can revert this.

Screenshot 2023-02-01 at 10 45 29 AM

@1ec5
Copy link
Member

1ec5 commented Feb 1, 2023

I also removed the light beams from the Lake Erie shield since I found them distracting. If people liked the other one better I can revert this.

The light beams are kind of cute; they probably make the lighthouse more recognizable. Does shortening the light beams help?

@quincylvania
Copy link
Contributor Author

Okay, I can live with this.

Screenshot 2023-02-01 at 1 09 56 PM

@claysmalley
Copy link
Member

Looks good to me overall! Don't forget npm run code_format.

ZeLonewolf
ZeLonewolf approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, everyone! 👍

@ZeLonewolf ZeLonewolf merged commit d60aa11 into osm-americana:main Feb 1, 2023
@quincylvania quincylvania deleted the great-lakes-circle-tour branch February 1, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 left review comments

@ZeLonewolf ZeLonewolf ZeLonewolf approved these changes

@claysmalley claysmalley Awaiting requested review from claysmalley

Assignees
No one assigned
Labels
internationalization shields
Projects
Shield internationalization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Great Lakes Circle Tour
4 participants
@quincylvania @claysmalley @1ec5 @ZeLonewolf