Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lake Pontchartrain Causeway shield #740

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Add Lake Pontchartrain Causeway shield #740

merged 3 commits into from
Jan 31, 2023

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jan 29, 2023

Added a shield for the Lake Pontchartrain Causeway.

Mandeville Crossover

Fixes #734.

@1ec5 1ec5 added the shields label Jan 29, 2023
@1ec5 1ec5 self-assigned this Jan 29, 2023
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more or less okay to me. The circle seems a bit pixelated compared to the Lincoln Heritage shield, which is also round. But, this might just be a perceptual issue.

image

@1ec5
Copy link
Member Author

1ec5 commented Jan 31, 2023

Comparing the two shields from your 1× screenshots here and in #738, both appear as circles, but the antialiasing is slightly different because of the gray rim inside the causeway shield. The faux 3D effect on the Lincoln Heritage Trail shield also makes these shields more difficult to compare. To optimize the antialiasing at 1×, circular shields would need to be sized at a factor of 2 pixels, such as 16×16 pixels.

Lincoln Causeway

Lincoln Causeway

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The 16x16 versions are convincing that this is just a perceptual thing on my part.

@1ec5 1ec5 merged commit 7e9c396 into main Jan 31, 2023
@1ec5 1ec5 deleted the 1ec5-us-la-causeway-734 branch January 31, 2023 00:30
@ZeLonewolf
Copy link
Member

Oh, I see now that the problem was the parish boundary line running into the shield graphic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lake Pontchartrain Causeway shield
2 participants