-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shield for Western Ring Route in New Zealand #529
Conversation
Thanks @k-yle for opening a PR. I have questions. Is the WRR route relation separate from the route 18 relation? I would think that we would want a custom graphic for the route, much like we do for special turnpikes in the United States. This PR declares a pill shield, which draws a circle or pill around the value in |
yes, it's separate from SH 18, (this is the OSM relation). I saw that I wasn't sure if a custom graphic was appropriate in this case (?), since it's a pretty much just a circle with text inside. |
Oh, I see. Black on white WR in a pill does seem like a workable approximation in that case. |
Code looks essentially correct, needs a tile update to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the plain text approach is reasonable, though it at least seems important that the shield is a circle rather than a pill or oval. If we use ovalShield()
and specify a width of 20 it should make the shield circular.
Co-authored-by: Clay Smalley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @k-yle for your contribution! |
This PR adds a shield for
network=NZ:WRR
, which is a one-of-a-kind route (example 1, example 2)Related to #451