Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shield for Western Ring Route in New Zealand #529

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Add shield for Western Ring Route in New Zealand #529

merged 4 commits into from
Aug 17, 2022

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Aug 1, 2022

This PR adds a shield for network=NZ:WRR, which is a one-of-a-kind route (example 1, example 2)

Related to #451

@ZeLonewolf
Copy link
Member

Thanks @k-yle for opening a PR.

Looking at this image:
image

I have questions.

Is the WRR route relation separate from the route 18 relation? I would think that we would want a custom graphic for the route, much like we do for special turnpikes in the United States. This PR declares a pill shield, which draws a circle or pill around the value in ref, and I'm not sure that's really the behavior we're looking for here?

@k-yle
Copy link
Contributor Author

k-yle commented Aug 2, 2022

yes, it's separate from SH 18, (this is the OSM relation). I saw that US:IA uses the same style, and renders similarly to how the WR shields are signposted.

I wasn't sure if a custom graphic was appropriate in this case (?), since it's a pretty much just a circle with text inside.

@ZeLonewolf
Copy link
Member

Oh, I see. Black on white WR in a pill does seem like a workable approximation in that case.

@ZeLonewolf
Copy link
Member

Code looks essentially correct, needs a tile update to test.

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plain text approach is reasonable, though it at least seems important that the shield is a circle rather than a pill or oval. If we use ovalShield() and specify a width of 20 it should make the shield circular.

src/js/shield_defs.js Outdated Show resolved Hide resolved
@1ec5 1ec5 changed the title Add shield for NZ:WRR Add shield for Western Ring Route in New Zealand Aug 2, 2022
Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Screenshot from 2022-08-16 17-58-41

@ZeLonewolf ZeLonewolf merged commit de323e3 into osm-americana:main Aug 17, 2022
@ZeLonewolf
Copy link
Member

Thanks @k-yle for your contribution!

@k-yle k-yle deleted the patch-1 branch August 17, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants