Road class and bridge/junction disambiguation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the relative imporance of roads at all zooms (#84). As primary and lower roads all use the same style at a given zoom, their relative widths are now the indicator of their relative importance.
Low-zoom "stroke" rendering is now handled as a dark fill with thin light casing. At high zooms the color pallet flips to light fill. This addresses the bridge layering challenge noted in #169 by always using casing for all highways. Even without extra bridge rails, the light casing allows viewers to distinguish overlaps versus junctions in "stroke" style.
|
LA before: LA after: |
1ec5
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
I think the hairline casing works really well for distinguishing roads from each other. We’ll have to keep an eye on how it interacts with other backgrounds for landuse, but for now I’m not even worried about how it looks over water, because it’s thin enough to look like a normal road casing without appearing to be the color of land.
ZeLonewolf
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disambiguates highway (#84) levels by always showing primary and lower highways with either dark or light treatments rather than a mix of both. The current dark/light switch happens at z15, but it could be changed earlier or later.
Additionally, the dark treatment from highways changes from from using the fill layer to draw "strokes" (without a casing layer) to always drawing both the casing and fill layers, but using a light casing with dark fill and a dark casing with light fill at the different zooms of primary and down. This partially or fully addresses #169 by allowing the the dark treatment's lighter casing to disambiguate between junctions and bridges/overpasses.
LA (localhost, demo)
We may still wish to add additional rails as suggested in #169 , but the dark-style highway rendering used at the lower zooms is now not as problematic.
Another potential direction opened up by this change is using the dark style for all zooms and not switching to light at all, but that can be left for a future PR.