Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields of Kentucky #119

Merged
merged 16 commits into from
Feb 17, 2022
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions style/CONTRIBUTE.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,23 @@ Shields should target 8-12px text actual-size character heights for readability:
| <img src="../doc-img/10_px_text.svg" height=20 width=20 /> | 10px |
| <img src="../doc-img/8_px_text.svg" height=20 width=20 /> | 8px |
| <img src="../doc-img/6_px_text.svg" height=20 width=20 /> | 6px |

### Shield Definitions

The `loadShields` function in style/js/shield_defs.js contains a definition object for each shield displayed on the map. A definition object can contain the following properties:

- **`backgroundImage`** – A reference to the image file used as the shield background, based on the name of the file in style/icons/. To use a different image depending on the length of the inscribed text, specify an array of images.
- **`colorLighten`** – The color to recolor the background image by.
- **`norefImage`** – A reference to an alternative image file used when there is no `ref`. This is appropriate if some routes in the network have a `ref` tag and others do not.
1ec5 marked this conversation as resolved.
Show resolved Hide resolved
- **`notext`** – By default, a relation missing a `ref` tag will not appear as a shield. Set this property to `true` to display a shield even if it has no `ref`. This is appropriate for one-off shield networks, which are common for toll roads and touristic routes.
- **`padding`** – An object that specifies the amount of padding on each side of the inscribed text relative to the background image.
- **`textColor`** – The color of the inscribed text to superimpose on the background.
- **`textLayoutConstraint`** – A strategy for constraining the text within the background image, useful for shields of certain shapes.

1ec5 marked this conversation as resolved.
Show resolved Hide resolved
Additionally, **`refsByWayName`** is an object mapping way names to text that can be superimposed on the background as a fallback for a missing `ref` value. (`refsByWayName` implies `notext`.) This temporary fallback is designed for use in [limited situations](https://wiki.openstreetmap.org/wiki/United_States/Unusual_highway_networks) that meet each of the following criteria:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a pass on instructions for crafting a shield definition object. As part of these instructions, I detailed the rationale for refsByWayName with enough conditions that hopefully it won’t open the floodgates to any end-runs around OSM.


- Each route in a network has a distinct shield that is dominated by the road name as opposed to a glyph or logo.
- Each shield in the network differs by only the road name, not a number, initialism, or color.
- Each route would be recognizable by an initialism, even though it is not signposted.
1ec5 marked this conversation as resolved.
Show resolved Hide resolved

`refsByWayName` only works if there is no `ref` tag and the expression in the `routeConcurrency` function in style/layer/highway_shield.js includes the `name` property in the image name. The network needs to be listed as an input value that causes the `match` expression to append `name` to the image name.
6 changes: 6 additions & 0 deletions style/icons/shield40_us_ky_parkway.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 9 additions & 4 deletions style/js/shield.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,12 @@ function textColor(shieldDef) {
return "black";
}

function drawShield(network, ref) {
function drawShield(network, ref, wayName) {
var shieldDef = ShieldDef.shields[network];
var ctx = null;
var bannerCount = 0;
var padding = null;
var shieldBounds = null;

if (shieldDef == null) {
if (ref == "") {
Expand All @@ -135,9 +136,12 @@ function drawShield(network, ref) {
bannerCount = ShieldDef.getBannerCount(shieldDef);
padding = shieldDef.padding;

if (ref === "" && shieldDef.refsByWayName) {
ref = shieldDef.refsByWayName[wayName];
}

var shieldArtwork = getRasterShieldBlank(network, ref);
var compoundBounds = null;
var shieldBounds = null;

if (shieldArtwork == null) {
if (typeof shieldDef.backgroundDraw != "undefined") {
Expand Down Expand Up @@ -205,14 +209,15 @@ export function missingIconLoader(map, e) {
return;
}

var network_ref = id.split("_")[1];
var network_ref = id.split("\n")[1];
var network_ref_parts = network_ref.split("=");
var network = network_ref_parts[0];
var ref = network_ref_parts[1];
var wayName = id.split("\n")[2];

var colorLighten = ShieldDef.shieldLighten(network, ref);

var ctx = drawShield(network, ref);
var ctx = drawShield(network, ref, wayName);

if (ctx == null) {
//Does not meet the criteria to draw a shield
Expand Down
31 changes: 31 additions & 0 deletions style/js/shield_defs.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,37 @@ export function loadShields(shieldImages) {
};

shields["US:KY"] = roundedRectShield("white", "black", "black", 8, 1, null);
shields["US:KY:AA"] = {
backgroundImage: shieldImages.shield40_us_ky_parkway,
textColor: "#003f87",
padding: {
left: 2,
right: 2,
top: 2,
bottom: 6,
},
};
shields["US:KY:Parkway"] = Object.assign(
{
refsByWayName: {
"Audobon Parkway": "AU",
"Bluegrass Parkway": "BG",
"Bluegrass Pkwy": "BG",
"Cumberland Parkway": "LN",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inclusion of these spelled-out versions is for forward-compatibility with any Planetiler-generated vector tiles. Once onthegomap/planetiler#14 is implemented, we can delete these extra entries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this note as a comment here or open a new ticket so we don't lose track of it.

"Cumberland Pkwy": "LN",
"Hal Rogers Parkway": "HR",
"Hal Rogers Pkwy": "HR",
"Mountain Parkway": "MP",
"Mountain Pkwy": "MP",
"Purchase Parkway": "JC",
"Purchase Pkwy": "JC",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted these initialisms from KYTC’s internal alphanumeric route numbers. Some of them are pretty recognizable, but some like “JC” are more obscure. (It’s from the namesake in the official name.) For the benefit of non-locals who don’t remember the older, more usable shields, I’d be open to changing it to something more intuitive, like “P”, but such ad-hoc abbreviations definitely shouldn’t go into OSM.

"Western Kentucky Parkway": "WK",
"Western Kentucky Pkwy": "WK",
},
},
shields["US:KY:AA"]
);

shields["US:MI"] = diamondShield;

shields["US:MN"] = {
Expand Down
16 changes: 15 additions & 1 deletion style/layer/highway_shield.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,21 @@ function routeConcurrency(num) {
return [
"case",
["!=", ["get", "route_" + num], null],
["image", ["concat", "shield_", ["get", "route_" + num]]],
[
"image",
[
"concat",
"shield\n",
["get", "route_" + num],
[
"match",
["get", "route_" + num],
"US:KY:Parkway=",
["concat", "\n", ["get", "name"]],
"",
],
],
],
["literal", ""],
];
}
Expand Down