Update Node.js in CI #1166
Open
Update Node.js in CI #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from 18.x (maintenance LTS until next spring) to 22.x (active LTS for the coming year). Rather than repeating the version in every workflow, reference the tool version by filename. Rather than specifying an exact major version, allow actions/setup-node to use a version that matches the requirement of ">=18", which is likely to require adjusting this less often (assuming things don't break by surprise when the version changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from 18.x (maintenance LTS until next spring) to 20.x (maintenance LTS for a year past that).
Rather than repeating the version in every workflow, reference the tool version by filename.
Rather than specifying an exact major version, give actions/setup-node a range of major versions.
The node-canvas dependency has prebuilt binaries for up to node 20, so limit to that in engines. They have a version 3 release candidate that switches to N-API, which is a more stable interface that will ultimately avoid a lot of this trouble.
Because of the .npmrc, this will cause npm install to loudly fail on an unsupported version, even if one is willing to e.g. build node-canvas from source. Do
--no-engine-strictornpm_config_engine_strict=falsein the environment to ignore this.