Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mormon Pioneer and Pony Express National Historic Trail Auto Tour Route shields #1163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quincylvania
Copy link
Contributor

@quincylvania quincylvania commented Oct 18, 2024

These are just plain shield since we don't have permission to use NHT shields yet, but the routes are mapped.

Re: #1101

@quincylvania quincylvania changed the title Add Mormon Pioneer National Historic Trail Auto Tour Route shield Add Mormon Pioneer and Pony Express National Historic Trail Auto Tour Route shields Oct 20, 2024
@quincylvania
Copy link
Contributor Author

A note of caution, some of these NHT are collinear with long stretches of interstates and US routes, so the shields may show up at relatively low zooms. This is z6 in Utah with this PR. The orange blob looks kind of weird considering there is no graphic.

Screenshot 2024-10-21 at 10 44 50 AM

@1ec5
Copy link
Member

1ec5 commented Oct 21, 2024

I think I’d actually expect that behavior along long concurrencies. Shorter concurrencies would cause more confusion, so OpenMapTiles tries to omit short concurrencies, albeit somewhat clumsily: openmaptiles/openmaptiles#1553. Even if once we get permission to use more accurate NHT shields, users will probably need to consult the legend to decipher the pictogram. Unfortunately, overrideByName isn’t supported yet: #1165. I think a fix for that bug would mitigate user confusion enough to get away with these shield blanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants