KM498 🐛 Move functions to GithubService

docs/release_notes/0.0.92.md

@@ -4,6 +4,8 @@
 
 ## Bugfixes
 
+KM498 🐛 Move functions to GithubService (#917)
+
 ## Changes
 
 ## Other

pkg/client/github_client.go

@@ -113,11 +113,6 @@ type DeleteGithubDeployKeyOpts struct {
 type GithubService interface {
 	CreateGithubRepository(ctx context.Context, opts CreateGithubRepositoryOpts) (*GithubRepository, error)
 	DeleteGithubRepository(ctx context.Context, opts DeleteGithubRepositoryOpts) error
-	ListReleases(owner, repo string) ([]*github.RepositoryRelease, error)
-}
-
-// GithubAPI invokes the Github API
-type GithubAPI interface {
 	CreateRepositoryDeployKey(opts CreateGithubDeployKeyOpts) (*GithubDeployKey, error)
 	DeleteRepositoryDeployKey(opts DeleteGithubDeployKeyOpts) error
 	ListReleases(owner, repo string) ([]*github.RepositoryRelease, error)

pkg/controller/cluster/reconciliation/argocd_reconciler_test.go

@@ -169,6 +169,14 @@ func (m mockGithubService) ListReleases(_, _ string) ([]*github.RepositoryReleas
 	return nil, nil
 }
 
+func (m mockGithubService) CreateRepositoryDeployKey(_ client.CreateGithubDeployKeyOpts) (*client.GithubDeployKey, error) {
+	return nil, nil
+}
+
+func (m mockGithubService) DeleteRepositoryDeployKey(_ client.DeleteGithubDeployKeyOpts) error {
+	return nil
+}
+
 type mockArgoCDState struct {
 	exists bool
 }

pkg/upgrade/testhelper_github_service_mock_test.go

@@ -11,6 +11,14 @@ type githubServiceMock struct {
 	releases []*github.RepositoryRelease
 }
 
+func (g githubServiceMock) CreateRepositoryDeployKey(_ client.CreateGithubDeployKeyOpts) (*client.GithubDeployKey, error) {
+	panic("not needed by mock")
+}
+
+func (g githubServiceMock) DeleteRepositoryDeployKey(_ client.DeleteGithubDeployKeyOpts) error {
+	panic("not needed by mock")
+}
+
 func (g githubServiceMock) CreateGithubRepository(context.Context, client.CreateGithubRepositoryOpts) (*client.GithubRepository, error) {
 	panic("not needed by mock")
 }