Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

[NOTASK] Update goformation dependency that has breaking changes #310

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

paulbes
Copy link
Contributor

@paulbes paulbes commented Feb 12, 2021

Update goformation dependency that has breaking changes

Description

We submitted a fix for goformation a while back (awslabs/goformation#299), which has now been merged. This brings goformation up to the latest version.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paulbes paulbes requested a review from yngvark February 12, 2021 07:16
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #310 (a614351) into master (e58755b) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   31.05%   31.05%           
=======================================
  Files         124      124           
  Lines        4031     4031           
=======================================
  Hits         1252     1252           
  Misses       2779     2779           
Impacted Files Coverage Δ
pkg/cfn/components/certificate/certificate.go 100.00% <ø> (ø)
pkg/cfn/components/dbsubnetgroup/dbsubnetgroup.go 57.14% <ø> (ø)
pkg/cfn/components/hostedzone/hostedzone.go 83.33% <ø> (ø)
pkg/cfn/components/managedpolicy/managedpolicy.go 40.00% <ø> (ø)
pkg/cfn/components/subnet/subnet.go 13.88% <0.00%> (ø)
pkg/cfn/components/userpool/userpool.go 40.00% <0.00%> (ø)
...kg/cfn/components/userpoolclient/userpoolclient.go 40.00% <ø> (ø)
pkg/cfn/components/userpooluser/userpooluser.go 40.00% <ø> (ø)
pkg/cfn/output.go 100.00% <100.00%> (ø)

@paulbes paulbes merged commit b91b008 into master Feb 12, 2021
@paulbes paulbes deleted the NOTASK-update_some_deps branch February 12, 2021 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants